Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 22472006: Make HAVE(ISDEBUGGERPRESENT) a local macro (instead of a global macro) as it is only used in wtf/As… (Closed)

Created:
7 years, 4 months ago by ostap
Modified:
7 years, 4 months ago
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make HAVE(ISDEBUGGERPRESENT) a local macro (instead of a global macro) as it is only used in wtf/Assertions.cpp. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/wtf/Assertions.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/Platform.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ostap
7 years, 4 months ago (2013-08-11 07:21:21 UTC) #1
abarth-chromium
lgtm
7 years, 4 months ago (2013-08-12 19:43:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/22472006/1
7 years, 4 months ago (2013-08-12 19:44:12 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 22:21:56 UTC) #4
Message was sent while issue was closed.
Change committed as 155957

Powered by Google App Engine
This is Rietveld 408576698