Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: services/ui/gpu/gpu_service_impl.cc

Issue 2247183005: services/ui: Get rid of IPC::ChannelHandle type converter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a build error Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/gpu/gpu_service_impl.cc
diff --git a/services/ui/gpu/gpu_service_impl.cc b/services/ui/gpu/gpu_service_impl.cc
index f0e6013217e9cfce2a69e4126ecdd3117dd32999..adf7a1b282da22c0c615865f04be0cce591e6228 100644
--- a/services/ui/gpu/gpu_service_impl.cc
+++ b/services/ui/gpu/gpu_service_impl.cc
@@ -17,7 +17,8 @@ void EstablishGpuChannelDone(
int32_t client_id,
const IPC::ChannelHandle& channel_handle) {
// TODO(penghuang): Send the real GPUInfo to the client.
- callback.Run(client_id, mojom::ChannelHandle::From(channel_handle),
+ callback.Run(client_id,
+ mojo::ScopedMessagePipeHandle(channel_handle.mojo_handle),
dcheng 2016/08/17 19:38:29 Does ChannelHandle not have strong ownership of it
Peng 2016/08/17 19:59:17 IPC::ChannelHandle is more like a data struct inst
gpu::GPUInfo());
}
}

Powered by Google App Engine
This is Rietveld 408576698