Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: services/ui/gpu/gpu_service_impl.cc

Issue 2247183005: services/ui: Get rid of IPC::ChannelHandle type converter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix review issues Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/ui/common/gpu_type_converters_unittest.cc ('k') | services/ui/gpu/gpu_service_mus.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/gpu/gpu_service_impl.h" 5 #include "services/ui/gpu/gpu_service_impl.h"
6 6
7 #include "services/shell/public/cpp/connection.h" 7 #include "services/shell/public/cpp/connection.h"
8 #include "services/ui/common/gpu_type_converters.h" 8 #include "services/ui/common/gpu_type_converters.h"
9 #include "services/ui/gpu/gpu_service_mus.h" 9 #include "services/ui/gpu/gpu_service_mus.h"
10 10
11 namespace ui { 11 namespace ui {
12 12
13 namespace { 13 namespace {
14 14
15 void EstablishGpuChannelDone( 15 void EstablishGpuChannelDone(
16 const mojom::GpuService::EstablishGpuChannelCallback& callback, 16 const mojom::GpuService::EstablishGpuChannelCallback& callback,
17 int32_t client_id, 17 int32_t client_id,
18 const IPC::ChannelHandle& channel_handle) { 18 mojo::ScopedMessagePipeHandle handle) {
19 // TODO(penghuang): Send the real GPUInfo to the client. 19 // TODO(penghuang): Send the real GPUInfo to the client.
20 callback.Run(client_id, mojom::ChannelHandle::From(channel_handle), 20 callback.Run(client_id, std::move(handle), gpu::GPUInfo());
21 gpu::GPUInfo());
22 } 21 }
23 } 22 }
24 23
25 GpuServiceImpl::GpuServiceImpl( 24 GpuServiceImpl::GpuServiceImpl(
26 mojo::InterfaceRequest<mojom::GpuService> request) 25 mojo::InterfaceRequest<mojom::GpuService> request)
27 : binding_(this, std::move(request)) {} 26 : binding_(this, std::move(request)) {}
28 27
29 GpuServiceImpl::~GpuServiceImpl() {} 28 GpuServiceImpl::~GpuServiceImpl() {}
30 29
31 void GpuServiceImpl::EstablishGpuChannel( 30 void GpuServiceImpl::EstablishGpuChannel(
(...skipping 21 matching lines...) Expand all
53 const mojom::GpuService::CreateGpuMemoryBufferCallback& callback) { 52 const mojom::GpuService::CreateGpuMemoryBufferCallback& callback) {
54 NOTIMPLEMENTED(); 53 NOTIMPLEMENTED();
55 } 54 }
56 55
57 void GpuServiceImpl::DestroyGpuMemoryBuffer(mojom::GpuMemoryBufferIdPtr id, 56 void GpuServiceImpl::DestroyGpuMemoryBuffer(mojom::GpuMemoryBufferIdPtr id,
58 const gpu::SyncToken& sync_token) { 57 const gpu::SyncToken& sync_token) {
59 NOTIMPLEMENTED(); 58 NOTIMPLEMENTED();
60 } 59 }
61 60
62 } // namespace ui 61 } // namespace ui
OLDNEW
« no previous file with comments | « services/ui/common/gpu_type_converters_unittest.cc ('k') | services/ui/gpu/gpu_service_mus.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698