gpu: Use GpuMemoryBufferManager from GpuService when possible.

gpu: Use GpuMemoryBufferManager from GpuService when possible.

ui::GpuService creates a GpuMemoryBufferManager instance that communicates with
the gpu process over mojo (MojoGpuMemoryBufferManager). When running chrome as a
muc client, use this version of the GpuMemoryBufferManager, instead of the one
created in content. Add GpuChannelEstablishFactory::GetGpuMemoryBufferManager()
for this.

This makes it unnecessary to create the BrowserGpuChannelHostFactory or the
BrowserGpuMemoryBufferManager singleton intances when running chrome as a mus
client.

BUG=637920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a78e33dec9fd79c95f94fa865cdd37518d31d245
Cr-Commit-Position: refs/heads/master@{#412316}

[sadrul, 2016-08-16 02:07:49]

Description was changed from

==========
gpu: Use GpuMemoryBufferManager from GpuService when possible.

ui::GpuService creates a GpuMemoryBufferManager instance that communicates with
the gpu process over mojo (MojoGpuMemoryBufferManager). When running chrome as a
muc client, use this version of the GpuMemoryBufferManager, instead of the one
created in content. Add GpuChannelEstablishFactory::GetGpuMemoryBufferManager()
for this.

This makes it unnecessary to create the BrowserGpuChannelHostFactory or the
BrowserGpuMemoryBufferManager singleton intances when running chrome as a mus
client.

BUG=637920
==========

to

==========
gpu: Use GpuMemoryBufferManager from GpuService when possible.

ui::GpuService creates a GpuMemoryBufferManager instance that communicates with
the gpu process over mojo (MojoGpuMemoryBufferManager). When running chrome as a
muc client, use this version of the GpuMemoryBufferManager, instead of the one
created in content. Add GpuChannelEstablishFactory::GetGpuMemoryBufferManager()
for this.

This makes it unnecessary to create the BrowserGpuChannelHostFactory or the
BrowserGpuMemoryBufferManager singleton intances when running chrome as a mus
client.

BUG=637920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sadrul, 2016-08-16 02:07:58]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 02:08:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 03:13:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 03:13:09]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-08-16 07:20:25]

sadrul@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-08-16 17:09:46]

lgtm

[sadrul, 2016-08-16 17:51:20]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2016-08-16 17:51:21]

+sky@ for services/ui changes.

[sky, 2016-08-16 19:44:38]

LGTM

[sadrul, 2016-08-16 20:03:55]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-08-16 20:05:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 20:11:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-16 20:13:55]

Description was changed from

==========
gpu: Use GpuMemoryBufferManager from GpuService when possible.

ui::GpuService creates a GpuMemoryBufferManager instance that communicates with
the gpu process over mojo (MojoGpuMemoryBufferManager). When running chrome as a
muc client, use this version of the GpuMemoryBufferManager, instead of the one
created in content. Add GpuChannelEstablishFactory::GetGpuMemoryBufferManager()
for this.

This makes it unnecessary to create the BrowserGpuChannelHostFactory or the
BrowserGpuMemoryBufferManager singleton intances when running chrome as a mus
client.

BUG=637920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Use GpuMemoryBufferManager from GpuService when possible.

ui::GpuService creates a GpuMemoryBufferManager instance that communicates with
the gpu process over mojo (MojoGpuMemoryBufferManager). When running chrome as a
muc client, use this version of the GpuMemoryBufferManager, instead of the one
created in content. Add GpuChannelEstablishFactory::GetGpuMemoryBufferManager()
for this.

This makes it unnecessary to create the BrowserGpuChannelHostFactory or the
BrowserGpuMemoryBufferManager singleton intances when running chrome as a mus
client.

BUG=637920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a78e33dec9fd79c95f94fa865cdd37518d31d245
Cr-Commit-Position: refs/heads/master@{#412316}
==========

[commit-bot: I haz the power, 2016-08-16 20:13:56]

Patchset 1 (id:??) landed as
https://crrev.com/a78e33dec9fd79c95f94fa865cdd37518d31d245
Cr-Commit-Position: refs/heads/master@{#412316}

[reveman, 2016-10-03 15:26:31]

reveman@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2016-10-03 15:26:32]

MojoGpuMemoryBufferManager seem to be lacking native GpuMemoryBuffer support.
How does this change not disable native gpu memory buffer support on intel based
ChromeOS devices where this is currently used?

[sadrul, 2016-10-03 17:28:54]

On 2016/10/03 15:26:32, reveman wrote:
> MojoGpuMemoryBufferManager seem to be lacking native GpuMemoryBuffer support.
> How does this change not disable native gpu memory buffer support on intel
based
> ChromeOS devices where this is currently used?

It is missing. I am refactoring this part of the code so mus does what chrome is
doing. (the hope is that we will use the same implementation on both chrome and
mus)

[reveman, 2016-10-03 19:31:59]

On 2016/10/03 at 17:28:54, sadrul wrote:
> On 2016/10/03 15:26:32, reveman wrote:
> > MojoGpuMemoryBufferManager seem to be lacking native GpuMemoryBuffer
support.
> > How does this change not disable native gpu memory buffer support on intel
based
> > ChromeOS devices where this is currently used?
> 
> It is missing. I am refactoring this part of the code so mus does what chrome
is doing. (the hope is that we will use the same implementation on both chrome
and mus)

Can we revert this for ChromeOS until fixed? This is currently causing a
performance/power regression in M54 for Broadwell, Haswell and Skylake based
Chromebooks. It's especially confusing as chrome://gpu is reporting that native
GMBs are used but under the hood they are not.

[sadrul, 2016-10-03 19:48:32]

On 2016/10/03 19:31:59, reveman wrote:
> On 2016/10/03 at 17:28:54, sadrul wrote:
> > On 2016/10/03 15:26:32, reveman wrote:
> > > MojoGpuMemoryBufferManager seem to be lacking native GpuMemoryBuffer
> support.
> > > How does this change not disable native gpu memory buffer support on intel
> based
> > > ChromeOS devices where this is currently used?
> > 
> > It is missing. I am refactoring this part of the code so mus does what
chrome
> is doing. (the hope is that we will use the same implementation on both chrome
> and mus)
> 
> Can we revert this for ChromeOS until fixed? This is currently causing a
> performance/power regression in M54 for Broadwell, Haswell and Skylake based
> Chromebooks. It's especially confusing as chrome://gpu is reporting that
native
> GMBs are used but under the hood they are not.

Oh? MojoGpuMemoryBufferManager is not actually used on any releases yet. It
should not be affecting anything.

[reveman, 2016-10-03 19:52:46]

On 2016/10/03 at 19:48:32, sadrul wrote:
> On 2016/10/03 19:31:59, reveman wrote:
> > On 2016/10/03 at 17:28:54, sadrul wrote:
> > > On 2016/10/03 15:26:32, reveman wrote:
> > > > MojoGpuMemoryBufferManager seem to be lacking native GpuMemoryBuffer
> > support.
> > > > How does this change not disable native gpu memory buffer support on
intel
> > based
> > > > ChromeOS devices where this is currently used?
> > > 
> > > It is missing. I am refactoring this part of the code so mus does what
chrome
> > is doing. (the hope is that we will use the same implementation on both
chrome
> > and mus)
> > 
> > Can we revert this for ChromeOS until fixed? This is currently causing a
> > performance/power regression in M54 for Broadwell, Haswell and Skylake based
> > Chromebooks. It's especially confusing as chrome://gpu is reporting that
native
> > GMBs are used but under the hood they are not.
> 
> Oh? MojoGpuMemoryBufferManager is not actually used on any releases yet. It
should not be affecting anything.

Ah I see now. It's protected by the IsRunningInMash condition:
https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.cc?r...

Sorry for the noise.