blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java - Issue 2247143004: Remove app context init from LibraryLoader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java

Issue 2247143004: Remove app context init from LibraryLoader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing setUp calls. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java ('K') | « base/android/javatests/src/org/chromium/base/metrics/RecordHistogramTest.java ('k') | blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java

diff --git a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java

index 290c4dbb4f01cd79833dd35486486430b9d75b1d..66614f8354ee3a56f389a0692a0ef7c4863c60d2 100644

--- a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java

+++ b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java

@@ -45,7 +45,7 @@ public final class BlimpLibraryLoader {

* A list of {@link Callback} instances that still need to be notified of the result of the

* initial call to {@link #startAsync(Context, Callback)}.

- private static ObserverList<Callback> sOutstandingCallbacks = new ObserverList<Callback>();

+ private static ObserverList<Callback> sOutstandingCallbacks = new ObserverList<>();

/**

* Disallow instantiation of this class.

@@ -85,7 +85,8 @@ public final class BlimpLibraryLoader {

ResourceExtractor extractor = ResourceExtractor.get(context);

extractor.startExtractingResources();

- LibraryLoader.get(LibraryProcessType.PROCESS_BROWSER).ensureInitialized(context);

+ LibraryLoader.get(LibraryProcessType.PROCESS_BROWSER)

+ .ensureInitialized(context.getApplicationContext());

extractor.addCompletionCallback(new Runnable() {

@Override