Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java

Issue 2247143004: Remove app context init from LibraryLoader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing setUp calls. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/android/javatests/src/org/chromium/base/EarlyTraceEventTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
diff --git a/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java b/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
index 454b167c9e20559b6fbefbec71f96945a7945c90..03495eeb3910e41cc7b81c16f2df1195c3fe01a3 100644
--- a/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
+++ b/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
@@ -133,8 +133,6 @@ public class LibraryLoader {
* @param context The context in which the method is called.
*/
public void ensureInitialized(Context context) throws ProcessInitException {
Torne 2016/08/18 14:44:55 Why do we still need to pass the app context in he
Peter Wen 2016/08/18 16:30:01 Done. We can actually do this at all the places w
- // TODO(wnwen): Move this call appropriately down to the tests that need it.
- ContextUtils.initApplicationContext(context.getApplicationContext());
synchronized (sLock) {
if (mInitialized) {
// Already initialized, nothing to do.
« no previous file with comments | « no previous file | base/android/javatests/src/org/chromium/base/EarlyTraceEventTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698