Issue 224713017: Remove IPC dependency from base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 224713017: Remove IPC dependency from base (Closed)

Created:
6 years, 8 months ago by brettw

Modified:
6 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, jar (doing other things), jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, erikwright+watch_chromium.org, Ilya Sherman, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pass the shared memory handle in to StatsTable rather than consulting the GlobaDescriptors. Remove the IPC dependency from base and updates the DEPS files to prevent this from happening again (ipc is in the root dir's deps file so is implicitly allowed here). The Chrome unit tests did a bunch of work to delete the stats file when running under Posix. But this filename is never used on Posix, so I deleted this code. The unit tests now use an anonymous stats table which this code now supports. The stats table unit test is disabled. It does not work on Posix systems at all because handle sharing is not set up. I put a Windows ifdef around this code (leaving it disabled) so I could use the Windows-style initializers, and verified that the test passes on Windows if I undisable it. R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262540

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -109 lines)			Patch
M	base/DEPS	View		1 chunk	+3 lines, -0 lines	1 comment	Download
M	base/metrics/stats_table.h	View		1 chunk	+27 lines, -6 lines	0 comments	Download
M	base/metrics/stats_table.cc	View	1 2	8 chunks	+31 lines, -29 lines	0 comments	Download
M	base/metrics/stats_table_unittest.cc	View	1 2	12 chunks	+10 lines, -36 lines	0 comments	Download
M	chrome/test/base/chrome_unit_test_suite.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/base/chrome_unit_test_suite.cc	View		3 chunks	+4 lines, -14 lines	0 comments	Download
M	content/app/content_main_runner.cc	View	1	4 chunks	+21 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

Committed patchset #3 manually as r262540 (presubmit successful).

6 years, 8 months ago (2014-04-08 23:14:11 UTC) #3

tfarina

6 years, 8 months ago (2014-04-10 00:17:23 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/224713017/diff/40001/base/DEPS
File base/DEPS (right):

https://codereview.chromium.org/224713017/diff/40001/base/DEPS#newcode8
base/DEPS:8: "+third_party/google_toolbox_for_mac/src",
ouch, base depends on this? sniff, sniff :-/

Expand Messages | Collapse Messages

Issue 224713017: Remove IPC dependency from base (Closed)

Description

Patch Set 1 #

Patch Set 2 : unit test compile #

Patch Set 3 : unit tests #

Messages