|
|
Created:
6 years, 8 months ago by Alexander Potapenko Modified:
6 years, 7 months ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionDo not instrument mutate.cc and generate.cc with AddressSanitizer
Compilation of these files w/instrumentation takes too long.
This is a temporary workaround for issue 360158
BUG=360158
R=thakis@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266983
Patch Set 1 #
Messages
Total messages: 17 (0 generated)
PTAL
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/224713013/1
The CQ bit was unchecked by thakis@chromium.org
(Looks like increasing the timeout on the bot was Good Enough, so I unchecked the cq box.)
On 2014/04/07 16:03:43, Nico wrote: > (Looks like increasing the timeout on the bot was Good Enough, so I unchecked > the cq box.) It is a fuzzer used only by security team (and not users). So, instrumentation is not needed here. The timeout setting is only changed on ASAN release and not any other ASAN/TSAN bots. We should let this one in so that we can save some time and not run into this problem on other bots in future.
On 2014/04/07 16:06:31, aarya wrote: > On 2014/04/07 16:03:43, Nico wrote: > > (Looks like increasing the timeout on the bot was Good Enough, so I unchecked > > the cq box.) > > It is a fuzzer used only by security team (and not users). I think this is a good argument to keep as much knowledge about this build configuration out of the public code base, no? >So, instrumentation > is not needed here. The timeout setting is only changed on ASAN release and not > any other ASAN/TSAN bots. We should let this one in so that we can save some > time and not run into this problem on other bots in future.
(I mean, if you want to land this, go ahead, but I'm guessing the cycle time of that builder isn't critical as long as it's green and completes in less than an hour?)
As long as increasing the timeout helps we can live without this patch. On Apr 7, 2014 8:14 PM, <thakis@chromium.org> wrote: > (I mean, if you want to land this, go ahead, but I'm guessing the cycle > time of > that builder isn't critical as long as it's green and completes in less > than an > hour?) > > https://codereview.chromium.org/224713013/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
On 2014/04/07 16:22:19, Alexander Potapenko wrote: > As long as increasing the timeout helps we can live without this patch. > On Apr 7, 2014 8:14 PM, <mailto:thakis@chromium.org> wrote: > > > (I mean, if you want to land this, go ahead, but I'm guessing the cycle > > time of > > that builder isn't critical as long as it's green and completes in less > > than an > > hour?) > > > > https://codereview.chromium.org/224713013/ > > > > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. See https://code.google.com/p/chromium/issues/detail?id=360158#c14. I am cqing this to fix ASAN bots. This is fuzzer code and does not need any instrumentation.
The CQ bit was checked by inferno@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/224713013/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
The CQ bit was checked by inferno@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/224713013/1
Message was sent while issue was closed.
Change committed as 266983 |