Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 224713013: Do not instrument mutate.cc and generate.cc with AddressSanitizer (Closed)

Created:
6 years, 8 months ago by Alexander Potapenko
Modified:
6 years, 7 months ago
Reviewers:
Nico, inferno
CC:
chromium-reviews
Visibility:
Public.

Description

Do not instrument mutate.cc and generate.cc with AddressSanitizer Compilation of these files w/instrumentation takes too long. This is a temporary workaround for issue 360158 BUG=360158 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M tools/ipc_fuzzer/mutate/mutate.gyp View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Alexander Potapenko
PTAL
6 years, 8 months ago (2014-04-07 13:37:16 UTC) #1
inferno
lgtm
6 years, 8 months ago (2014-04-07 13:59:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/224713013/1
6 years, 8 months ago (2014-04-07 13:59:16 UTC) #3
Nico
The CQ bit was unchecked by thakis@chromium.org
6 years, 8 months ago (2014-04-07 16:03:10 UTC) #4
Nico
(Looks like increasing the timeout on the bot was Good Enough, so I unchecked the ...
6 years, 8 months ago (2014-04-07 16:03:43 UTC) #5
aarya
On 2014/04/07 16:03:43, Nico wrote: > (Looks like increasing the timeout on the bot was ...
6 years, 8 months ago (2014-04-07 16:06:31 UTC) #6
Nico
On 2014/04/07 16:06:31, aarya wrote: > On 2014/04/07 16:03:43, Nico wrote: > > (Looks like ...
6 years, 8 months ago (2014-04-07 16:13:59 UTC) #7
Nico
(I mean, if you want to land this, go ahead, but I'm guessing the cycle ...
6 years, 8 months ago (2014-04-07 16:14:56 UTC) #8
Alexander Potapenko
As long as increasing the timeout helps we can live without this patch. On Apr ...
6 years, 8 months ago (2014-04-07 16:22:19 UTC) #9
inferno
On 2014/04/07 16:22:19, Alexander Potapenko wrote: > As long as increasing the timeout helps we ...
6 years, 7 months ago (2014-04-29 17:59:44 UTC) #10
inferno
The CQ bit was checked by inferno@chromium.org
6 years, 7 months ago (2014-04-29 17:59:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/224713013/1
6 years, 7 months ago (2014-04-29 18:01:28 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 18:47:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 18:47:08 UTC) #14
inferno
The CQ bit was checked by inferno@chromium.org
6 years, 7 months ago (2014-04-29 18:58:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/224713013/1
6 years, 7 months ago (2014-04-29 18:58:46 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 22:51:03 UTC) #17
Message was sent while issue was closed.
Change committed as 266983

Powered by Google App Engine
This is Rietveld 408576698