Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2247113003: Speed up centered hard stop shader (Closed)

Created:
4 years, 4 months ago by fmenozzi
Modified:
4 years, 4 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reducing number of calls to GLSL mix() from two to one reduces frame render time by 21% BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2247113003 Committed: https://skia.googlesource.com/skia/+/af23ee538b5a007c2c9ca12ae6e54b2e0ed29876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
fmenozzi
ptal
4 years, 4 months ago (2016-08-16 14:01:59 UTC) #3
tomhudson
LGTM. Nit: since you don't have a tracking bug, just a single sentence here in ...
4 years, 4 months ago (2016-08-16 14:05:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247113003/1
4 years, 4 months ago (2016-08-16 14:22:04 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 16:24:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/af23ee538b5a007c2c9ca12ae6e54b2e0ed29876

Powered by Google App Engine
This is Rietveld 408576698