Restore SkPath(const SkPath&) to copy the generation ID on Android.

include/core/SkPath.h

Index: include/core/SkPath.h
diff --git a/include/core/SkPath.h b/include/core/SkPath.h
index d4b79cda0443cd73417dde72e9d3a6f786737e01..f022d45eb11c358b9ff21b7ad5c23395c8289e7a 100644
--- a/include/core/SkPath.h
+++ b/include/core/SkPath.h
@@ -40,11 +40,10 @@ public:
     SK_DECLARE_INST_COUNT_ROOT(SkPath);
 
     SkPath();
-    SkPath(const SkPath&);
+    SkPath(const SkPath&);             // Copies fGenerationID on Android.
+    SkPath& operator=(const SkPath&);  // Does not copy fGenerationID on Android.

[bungeman-skia, 2013/08/06 20:09:48]

Just for the parallel (and positive) construction: 

Increments fGenerationID on Android.

[mtklein, 2013/08/06 20:23:35]

Done.

     ~SkPath();
 
-    SkPath& operator=(const SkPath&);
-
     friend  SK_API bool operator==(const SkPath&, const SkPath&);
     friend bool operator!=(const SkPath& a, const SkPath& b) {
         return !(a == b);
@@ -167,14 +166,12 @@ public:
 
     /** Clear any lines and curves from the path, making it empty. This frees up
         internal storage associated with those segments.
-        This does NOT change the fill-type setting nor isConvex
     */
     void reset();
 
     /** Similar to reset(), in that all lines and curves are removed from the
         path. However, any internal storage for those lines/curves is retained,
         making reuse of the path potentially faster.
-        This does NOT change the fill-type setting nor isConvex
     */
     void rewind();
 
@@ -965,8 +962,7 @@ private:
 
     /** Sets all fields other than fPathRef to the values in 'that'.
      *  Assumes the caller has already set fPathRef.
-     *  On Android increments fGenerationID without copying it.
-     *  On Android sets fSourcePath to NULL.
+     *  Doesn't change fGenerationID or fSourcePath on Android, leaving these to the caller too.

[bungeman-skia, 2013/08/06 20:09:48]

Perhaps,

On Android does not set fGenerationID or fSourcePath.

[mtklein, 2013/08/06 20:23:35]

Done.

      */
     void copyFields(const SkPath& that);