Restore SkPath(const SkPath&) to copy the generation ID on Android.

Restore SkPath(const SkPath&) to copy the generation ID on Android.

BUG=
R=bsalomon@google.com, bungeman@google.com, reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10622

[bungeman-skia, 2013-08-06 20:09:48]

https://codereview.chromium.org/22471002/diff/8001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/22471002/diff/8001/src/core/SkPath.cpp#newcod...
src/core/SkPath.cpp:220: fGenerationID    = that.fGenerationID;
Similar situation to swap. Can't this make this object's generation ID go
backwards (for operator=)?

https://codereview.chromium.org/22471002/diff/12001/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/22471002/diff/12001/include/core/SkPath.h#new...
include/core/SkPath.h:44: SkPath& operator=(const SkPath&);  // Does not copy
fGenerationID on Android.
Just for the parallel (and positive) construction: 

Increments fGenerationID on Android.

https://codereview.chromium.org/22471002/diff/12001/include/core/SkPath.h#new...
include/core/SkPath.h:965: *  Doesn't change fGenerationID or fSourcePath on
Android, leaving these to the caller too.
Perhaps,

On Android does not set fGenerationID or fSourcePath.

[reed1, 2013-08-06 20:16:47]

(when) can we switch android over to using SkPath's native genID?

[bungeman-skia, 2013-08-06 20:22:42]

@djsolen

On 2013/08/06 20:16:47, reed1 wrote:
> (when) can we switch android over to using SkPath's native genID?

[mtklein, 2013-08-06 20:23:35]

https://codereview.chromium.org/22471002/diff/8001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/22471002/diff/8001/src/core/SkPath.cpp#newcod...
src/core/SkPath.cpp:220: fGenerationID    = that.fGenerationID;
On 2013/08/06 20:09:48, bungeman1 wrote:
> Similar situation to swap. Can't this make this object's generation ID go
> backwards (for operator=)?

Done.

https://codereview.chromium.org/22471002/diff/12001/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/22471002/diff/12001/include/core/SkPath.h#new...
include/core/SkPath.h:44: SkPath& operator=(const SkPath&);  // Does not copy
fGenerationID on Android.
On 2013/08/06 20:09:48, bungeman1 wrote:
> Just for the parallel (and positive) construction: 
> 
> Increments fGenerationID on Android.

Done.

https://codereview.chromium.org/22471002/diff/12001/include/core/SkPath.h#new...
include/core/SkPath.h:965: *  Doesn't change fGenerationID or fSourcePath on
Android, leaving these to the caller too.
On 2013/08/06 20:09:48, bungeman1 wrote:
> Perhaps,
> 
> On Android does not set fGenerationID or fSourcePath.

Done.

[reed1, 2013-08-06 21:15:08]

lgtm w/ nit

https://codereview.chromium.org/22471002/diff/18001/include/core/SkPath.h
File include/core/SkPath.h (left):

https://codereview.chromium.org/22471002/diff/18001/include/core/SkPath.h#old...
include/core/SkPath.h:170: This does NOT change the fill-type setting nor
isConvex
Were these comments wrong or misleading?

https://codereview.chromium.org/22471002/diff/18001/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/22471002/diff/18001/include/core/SkPath.h#new...
include/core/SkPath.h:44: SkPath& operator=(const SkPath&);  // Increments
fGenerationID on Android.
:( nit: Skia mostly likes only constructors/destruct in the first block.

[bungeman-skia, 2013-08-06 21:16:52]

lgtm

[mtklein, 2013-08-06 21:18:46]

https://codereview.chromium.org/22471002/diff/18001/include/core/SkPath.h
File include/core/SkPath.h (left):

https://codereview.chromium.org/22471002/diff/18001/include/core/SkPath.h#old...
include/core/SkPath.h:170: This does NOT change the fill-type setting nor
isConvex
On 2013/08/06 21:15:09, reed1 wrote:
> Were these comments wrong or misleading?

Yes, wrong.  The same CL that caused the bug changed these too.  They both set
fill type to winding and convexity to unknown now.

https://codereview.chromium.org/22471002/diff/18001/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/22471002/diff/18001/include/core/SkPath.h#new...
include/core/SkPath.h:44: SkPath& operator=(const SkPath&);  // Increments
fGenerationID on Android.
On 2013/08/06 21:15:09, reed1 wrote:
> :( nit: Skia mostly likes only constructors/destruct in the first block.

Done.

[bsalomon, 2013-08-06 22:06:29]

lgtm

[mtklein, 2013-08-07 19:17:59]

Committed patchset #9 manually as r10622 (presubmit successful).