Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2247093002:
PPC/s390: [wasm] adding case for kAttachedReference in Serializer/Deseriealizer (Closed)
|
Created:
4 years, 4 months ago by JaideepBajwa Modified:
4 years, 4 months ago CC:
v8-reviews_googlegroups.com, Yang, JoranSiu, john.yan, michael_dawson, MTBrandyberry, v8-mips-ports_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionPPC/s390: [wasm] adding case for kAttachedReference in Serializer/Deseriealizer
For PPC/s390 the case is missing where reference=attachedreference
how_to_code=kFromCode and where_to_point=kStartOfObject. On PPC/s390
IsCodedSpecially always return true, hence how_to_code will not be a
straight pointer.
This should also fix the similar issue on mipsel.
The testcase was added as part of https://codereview.chromium.org/2205973003/
R=mtrofin@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG=
LOG=N
Committed: https://crrev.com/2e6db3af00282c35a7d944ac76f3280f626c0ee7
Cr-Commit-Position: refs/heads/master@{#38789}
Patch Set 1 #
Messages
Total messages: 25 (11 generated)
PTAL
Description was changed from ========== PPC/s390: [wasm] adding case for kAttachedReference in Serializer/Deseriealizer For PPC/s390 the case is missing where reference=attachedreference how_to_code=kFromCode and where_to_point=kStartOfObject. On PPC/s390 IsCodedSpecially always return true, hence how_to_code will not be a straight pointer. This should also fix the similar issue on mipsel. The testcase was added as part of https://codereview.chromium.org/2205973003/ R=mtrofin@chromium.org, yangguo@chromium.org, titzer@chromium.org BUG= LOG=N ========== to ========== PPC/s390: [wasm] adding case for kAttachedReference in Serializer/Deseriealizer For PPC/s390 the case is missing where reference=attachedreference how_to_code=kFromCode and where_to_point=kStartOfObject. On PPC/s390 IsCodedSpecially always return true, hence how_to_code will not be a straight pointer. This should also fix the similar issue on mipsel. The testcase was added as part of https://codereview.chromium.org/2205973003/ R=mtrofin@chromium.org, yangguo@chromium.org, titzer@chromium.org BUG= LOG=N ==========
mtrofin@chromium.org changed required reviewers: + yangguo@chromium.org
On 2016/08/15 22:24:30, JaideepBajwa wrote: > PTAL LGTM, but I'd like Yang to take a look at it, too.
On 2016/08/17 19:19:17, Mircea Trofin wrote: > On 2016/08/15 22:24:30, JaideepBajwa wrote: > > PTAL > > LGTM, but I'd like Yang to take a look at it, too. Yang is on vacation. LGTM too
On 2016/08/18 08:53:30, titzer wrote: > On 2016/08/17 19:19:17, Mircea Trofin wrote: > > On 2016/08/15 22:24:30, JaideepBajwa wrote: > > > PTAL > > > > LGTM, but I'd like Yang to take a look at it, too. > > Yang is on vacation. LGTM too Thank you.
The CQ bit was checked by bjaideep@ca.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
titzer@chromium.org changed reviewers: + verwaest@chromium.org
On 2016/08/18 12:09:33, commit-bot: I haz the power wrote: > All required reviewers (with asterisk prefixes) have not yet approved this CL. > > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > Committers are members of the group "project-v8-committers". > Note that this has nothing to do with OWNERS files. +verwaest
rubberstamp lgtm
The CQ bit was checked by bjaideep@ca.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
On 2016/08/18 14:43:49, commit-bot: I haz the power wrote: > All required reviewers (with asterisk prefixes) have not yet approved this CL. > > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > Committers are members of the group "project-v8-committers". > Note that this has nothing to do with OWNERS files. Since Yang is on vacation, is there someone else from the group "project-v8-committers" who can review this CL? Thanks.
verwaest@chromium.org changed required reviewers: - yangguo@chromium.org
The CQ bit was checked by verwaest@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== PPC/s390: [wasm] adding case for kAttachedReference in Serializer/Deseriealizer For PPC/s390 the case is missing where reference=attachedreference how_to_code=kFromCode and where_to_point=kStartOfObject. On PPC/s390 IsCodedSpecially always return true, hence how_to_code will not be a straight pointer. This should also fix the similar issue on mipsel. The testcase was added as part of https://codereview.chromium.org/2205973003/ R=mtrofin@chromium.org, yangguo@chromium.org, titzer@chromium.org BUG= LOG=N ========== to ========== PPC/s390: [wasm] adding case for kAttachedReference in Serializer/Deseriealizer For PPC/s390 the case is missing where reference=attachedreference how_to_code=kFromCode and where_to_point=kStartOfObject. On PPC/s390 IsCodedSpecially always return true, hence how_to_code will not be a straight pointer. This should also fix the similar issue on mipsel. The testcase was added as part of https://codereview.chromium.org/2205973003/ R=mtrofin@chromium.org, yangguo@chromium.org, titzer@chromium.org BUG= LOG=N ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== PPC/s390: [wasm] adding case for kAttachedReference in Serializer/Deseriealizer For PPC/s390 the case is missing where reference=attachedreference how_to_code=kFromCode and where_to_point=kStartOfObject. On PPC/s390 IsCodedSpecially always return true, hence how_to_code will not be a straight pointer. This should also fix the similar issue on mipsel. The testcase was added as part of https://codereview.chromium.org/2205973003/ R=mtrofin@chromium.org, yangguo@chromium.org, titzer@chromium.org BUG= LOG=N ========== to ========== PPC/s390: [wasm] adding case for kAttachedReference in Serializer/Deseriealizer For PPC/s390 the case is missing where reference=attachedreference how_to_code=kFromCode and where_to_point=kStartOfObject. On PPC/s390 IsCodedSpecially always return true, hence how_to_code will not be a straight pointer. This should also fix the similar issue on mipsel. The testcase was added as part of https://codereview.chromium.org/2205973003/ R=mtrofin@chromium.org, yangguo@chromium.org, titzer@chromium.org BUG= LOG=N Committed: https://crrev.com/2e6db3af00282c35a7d944ac76f3280f626c0ee7 Cr-Commit-Position: refs/heads/master@{#38789} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2e6db3af00282c35a7d944ac76f3280f626c0ee7 Cr-Commit-Position: refs/heads/master@{#38789} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
