Background tracing: Added config option for repeated trigger behavior

content/browser/tracing/background_tracing_rule.cc

Index: content/browser/tracing/background_tracing_rule.cc
diff --git a/content/browser/tracing/background_tracing_rule.cc b/content/browser/tracing/background_tracing_rule.cc
index c24896fc186474b4f6d2cafb8d36f953f78056ee..527d64afb42feb93ed8852a046d3868363b21d90 100644
--- a/content/browser/tracing/background_tracing_rule.cc
+++ b/content/browser/tracing/background_tracing_rule.cc
@@ -23,6 +23,8 @@ const char kConfigCategoryKey[] = "category";
 const char kConfigRuleTriggerNameKey[] = "trigger_name";
 const char kConfigRuleTriggerDelay[] = "trigger_delay";
 const char kConfigRuleTriggerChance[] = "trigger_chance";
+const char kConfigRuleStopTracingOnRepeatedReactive[] =
+    "stop_tracing_on_repeated_reactive";
 
 const char kConfigRuleHistogramNameKey[] = "histogram_name";
 const char kConfigRuleHistogramValueOldKey[] = "histogram_value";
@@ -59,11 +61,13 @@ namespace content {
 BackgroundTracingRule::BackgroundTracingRule()
     : trigger_chance_(1.0),
       trigger_delay_(-1),

[ssid, 2016/08/17 04:11:36]

From what I understand:
Probably unrelated to this CL, but this value is set to -1 by default.
Only the navigation config sets this value as 30 seconds. The HistogramRule
constructor never sets this value.
I thought this value was 30 by deafult. The memory triggers do not set this
delay value and we should be starting and stopping tracing immediately?
Or am I missing something? I think I should fix this in the config?

[shatch, 2016/08/17 14:53:58]

Yeah you should probably add a delay in your config, and maybe we want to set a
default in HistogramRule.

+      stop_tracing_on_repeated_reactive_(false),
       category_preset_(BackgroundTracingConfigImpl::CATEGORY_PRESET_UNSET) {}
 
 BackgroundTracingRule::BackgroundTracingRule(int trigger_delay)
     : trigger_chance_(1.0),
       trigger_delay_(trigger_delay),
+      stop_tracing_on_repeated_reactive_(false),
       category_preset_(BackgroundTracingConfigImpl::CATEGORY_PRESET_UNSET) {}
 
 BackgroundTracingRule::~BackgroundTracingRule() {}
@@ -85,6 +89,11 @@ void BackgroundTracingRule::IntoDict(base::DictionaryValue* dict) const {
   if (trigger_delay_ != -1)
     dict->SetInteger(kConfigRuleTriggerDelay, trigger_delay_);
 
+  if (stop_tracing_on_repeated_reactive_) {
+    dict->SetBoolean(kConfigRuleStopTracingOnRepeatedReactive,
+                     stop_tracing_on_repeated_reactive_);
+  }
+
   if (category_preset_ != BackgroundTracingConfigImpl::CATEGORY_PRESET_UNSET) {
     dict->SetString(
         kConfigCategoryKey,
@@ -95,6 +104,8 @@ void BackgroundTracingRule::IntoDict(base::DictionaryValue* dict) const {
 void BackgroundTracingRule::Setup(const base::DictionaryValue* dict) {
   dict->GetDouble(kConfigRuleTriggerChance, &trigger_chance_);
   dict->GetInteger(kConfigRuleTriggerDelay, &trigger_delay_);
+  dict->GetBoolean(kConfigRuleStopTracingOnRepeatedReactive,
+                   &stop_tracing_on_repeated_reactive_);
 }
 
 namespace {