Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: git_cl.py

Issue 224703002: Use get_or_create_merge_base in git-cl-upload to correctly deal with rebased (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: fix tests' Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 1a1c64847f26c098dd292278249108de56e42980..9dabe20889840485c07800df09deb96d50820f89 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -35,13 +35,14 @@ import breakpad # pylint: disable=W0611
import clang_format
import fix_encoding
import gclient_utils
+import git_common
+import owners_finder
import presubmit_support
import rietveld
import scm
import subcommand
import subprocess2
import watchlists
-import owners_finder
__version__ = '1.0'
@@ -551,7 +552,8 @@ or verify this branch is set up to track another (via the --track argument to
return remote, upstream_branch
def GetCommonAncestorWithUpstream(self):
- return RunGit(['merge-base', self.GetUpstreamBranch(), 'HEAD']).strip()
+ return git_common.get_or_create_merge_base(self.GetBranch(),
+ self.GetUpstreamBranch())
def GetUpstreamBranch(self):
if self.upstream_branch is None:
@@ -2155,7 +2157,7 @@ def CMDtry(parser, args):
"-bwin_rel:base_unittests:ValuesTest.*Value"))
group.add_option(
"-m", "--master", default='',
- help=("Specify a try master where to run the tries."))
+ help=("Specify a try master where to run the tries."))
group.add_option(
"-r", "--revision",
help="Revision to use for the try job; default: the "
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698