Implement ScriptPromise and ScriptFunction

Source/bindings/v8/GarbageCollected.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef ScopedPersistent_h
-#define ScopedPersistent_h
+#ifndef GarbageCollected_h
+#define GarbageCollected_h
 
+#include "wtf/Noncopyable.h"
 #include <v8.h>
-#include "wtf/Noncopyable.h"
 
 namespace WebCore {
 
 template<typename T>
-class ScopedPersistent {
-    WTF_MAKE_NONCOPYABLE(ScopedPersistent);
+class GarbageCollected {

[abarth-chromium, 2013/08/15 00:22:11]

Oh, sorry.  I meant that GarbageCollected would handle all the v8::External
work.  The idea is that if you wanted your C++ object to be garbage collected,
you'd subclass GarbageCollected.

class MyClass : public GarbageCollected<MyClass> {
public:
  void foo();
....
};

v8::Handle<v8::External> bar = MyClass::create(..);
MyClass::from(bar)->foo();

The idea is that GarbageCollected is an alternative to RefCounted as a base
class that defines how the class's memory is managed.

+    WTF_MAKE_NONCOPYABLE(GarbageCollected);
 public:
-    ScopedPersistent() { }
+    GarbageCollected() { }
 
-    explicit ScopedPersistent(v8::Handle<T> handle)
+    explicit GarbageCollected(v8::Handle<T> handle)
         : m_handle(v8::Isolate::GetCurrent(), handle)
     {
     }
 
-    ~ScopedPersistent()
+    ~GarbageCollected()
     {
         clear();
     }
 
     ALWAYS_INLINE v8::Local<T> newLocal(v8::Isolate* isolate) const
     {
         return v8::Local<T>::New(isolate, m_handle);
     }
 
-    template<typename P>
-    void makeWeak(P* parameters, void (*callback)(v8::Isolate*, v8::Persistent<T>*, P*))
-    {
-        m_handle.MakeWeak(parameters, callback);
-    }
-
     bool isEmpty() const { return m_handle.IsEmpty(); }
 
     void set(v8::Isolate* isolate, v8::Handle<T> handle)
     {
         m_handle.Reset(isolate, handle);
+        m_handle.MakeWeak(this, &weakCallback);
     }
-
     // Note: This is clear in the OwnPtr sense, not the v8::Handle sense.
     void clear()
     {
         if (m_handle.IsEmpty())
             return;
         m_handle.Dispose();
         m_handle.Clear();
     }
 
-    bool operator==(const ScopedPersistent<T>& other)
+    bool operator==(const GarbageCollected<T>& other)
     {
         return m_handle == other.m_handle;
     }
 
 private:
-    // FIXME: This function does an unsafe handle access. Remove it.
-    friend class V8AbstractEventListener;
-    friend class V8PerIsolateData;
-    ALWAYS_INLINE v8::Persistent<T>& getUnsafe()
+    static void weakCallback(v8::Isolate*, v8::Persistent<T>*, GarbageCollected<T>* self)
     {
-        return m_handle;
+        self->clear();
     }
 
     v8::Persistent<T> m_handle;
 };
 
 } // namespace WebCore
 
-#endif // ScopedPersistent_h
+#endif // GarbageCollected_h