Implement ScriptPromise and ScriptFunction

Source/bindings/v8/ScriptFunction.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef ScriptString_h
-#define ScriptString_h
+#ifndef ScriptFunction_h
+#define ScriptFunction_h
 
 #include "bindings/v8/ScriptValue.h"
 #include "bindings/v8/V8Binding.h"
-#include "wtf/text/WTFString.h"
+#include "wtf/RefCounted.h"
+#include <v8.h>
 
 namespace WebCore {
 
-class ScriptString : public ScriptValue {
+// to use this class,

[abarth-chromium, 2013/08/12 23:35:32]

I find this comment sort of confusing.  Can we unify the two pieces into one
comment somewhere?

+class ScriptFunction : public RefCounted<ScriptFunction> {
 public:
-    ScriptString() { }
-    explicit ScriptString(v8::Handle<v8::String> value) : ScriptValue(value) { }
+    ScriptFunction() { }
+    virtual ~ScriptFunction() { }
 
-    ScriptString concatenateWith(const String&);
-    String flattenToString() const;
+    // override this
+    virtual ScriptValue call(ScriptValue arg) { return ScriptValue(); }
+
+    v8::Handle<v8::Function> toV8(v8::Isolate* isolate)
+    {
+        if (m_function.isEmpty()) {
+            ref();

[abarth-chromium, 2013/08/12 23:35:32]

Last time I looked at this CL, I asked about factoring out a GarbageCollected
base class...  What do you think about that?

[alecflett, 2013/08/13 20:37:11]

Sorry, I forgot about that.

+            m_function.set(isolate, v8::FunctionTemplate::New(&callCallback, v8::External::New(this))->GetFunction());
+            m_function.makeWeak(this, &weakCallback);
+        }
+        return m_function.newLocal(isolate);
+    }
+
+private:
+    static void weakCallback(v8::Isolate*, v8::Persistent<v8::Function>*, ScriptFunction* self)
+    {
+        self->deref();
+        self->m_function.clear();
+    }
+
+    static void callCallback(const v8::FunctionCallbackInfo<v8::Value>& args)
+    {
+        v8::Isolate* isolate = args.GetIsolate();
+        ASSERT(!args.Data().IsEmpty());
+        ScriptFunction* function = static_cast<ScriptFunction*>(args.Data().As<v8::External>()->Value());
+        v8::Local<v8::Value> value = v8::Undefined(isolate);

[abarth-chromium, 2013/08/12 23:35:32]

It looks like you didn't address a number of comments from my last review...

[alecflett, 2013/08/13 20:37:11]

oops, not sure how the new version of this file didn't get uploaded. 

+        if (args.Length() > 0)
+            value = args[0];
+
+        ScriptValue result = function->call(ScriptValue(value));
+        v8SetReturnValue(args, result.v8Value());
+    }
+
+    ScopedPersistent<v8::Function> m_function;
+    friend class RefCounted<ScriptFunction>;
 };
 
 } // namespace WebCore
 
-#endif // ScriptString_h
+#endif