Implement ScriptPromise and ScriptFunction

Source/bindings/v8/ScriptFunction.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef LayerRect_h
-#define LayerRect_h
+#ifndef ScriptFunction_h
+#define ScriptFunction_h
 
-#include "core/dom/ClientRect.h"
+#include "ScriptValue.h"
+#include "V8Binding.h"

[abarth-chromium, 2013/08/09 21:46:52]

Please use paths from the Source directory

+#include "wtf/RefCounted.h"
 

[abarth-chromium, 2013/08/09 21:46:52]

No need for this blank line.

-#include "wtf/PassRefPtr.h"
-#include "wtf/RefCounted.h"
-#include "wtf/RefPtr.h"
+#include <v8.h>
 
 namespace WebCore {
 
-class Node;
+// to use this class,

[abarth-chromium, 2013/08/09 21:46:52]

?

+class ScriptFunction : public RefCounted<ScriptFunction> {
+public:
+    ScriptFunction() { }
+    virtual ~ScriptFunction() { }
 
-class LayerRect : public RefCounted<LayerRect> {
-public:
-    static PassRefPtr<LayerRect> create(PassRefPtr<Node> node, PassRefPtr<ClientRect> rect)
+    // override this
+    virtual ScriptValue call(ScriptValue arg) { return ScriptValue(); }
+
+    v8::Handle<v8::Function> toV8(v8::Isolate* isolate)
     {
-        return adoptRef(new LayerRect(node, rect));
+        if (m_function.isEmpty()) {
+            ref();

[abarth-chromium, 2013/08/09 21:46:52]

Rather than calling ref() and deref(), maybe we should abstract our a base class
called GarbageCollected that does this work?

+            m_function.set(isolate, v8::FunctionTemplate::New(&callCallback, v8::External::New(this))->GetFunction());
+            m_function.makeWeak(this, &weakCallback);
+        }
+        return m_function.newLocal(isolate);
     }
 
-    Node* layerRootNode() const { return m_layerRootNode.get(); }
-    ClientRect* layerRelativeRect() const { return m_rect.get(); }
-
 private:
-    LayerRect(PassRefPtr<Node> node, PassRefPtr<ClientRect> rect)
-        : m_layerRootNode(node)
-        , m_rect(rect)
+    static void weakCallback(v8::Isolate*, v8::Persistent<v8::Function>*, ScriptFunction* self)
     {
+        self->deref();

[abarth-chromium, 2013/08/09 21:46:52]

Don't we need to clear out m_function in this function?

     }
 
-    RefPtr<Node> m_layerRootNode;
-    RefPtr<ClientRect> m_rect;
+    static void callCallback(const v8::FunctionCallbackInfo<v8::Value>& args)
+    {
+        v8::Isolate* isolate = args.GetIsolate();
+        ASSERT(!args.Data().IsEmpty());
+        ScriptFunction* function = static_cast<ScriptFunction*>(args.Data().As<v8::External>()->Value());

[abarth-chromium, 2013/08/09 21:46:52]

We need to hold a RefPtr<ScriptFunction> here in case the garbage collector
decides to destroy function during this function.

+        v8::Local<v8::Value> value = v8::Undefined(isolate);
+        if (args.Length() > 0)
+            value = args[0];

[abarth-chromium, 2013/08/09 21:46:52]

Can we use the ? : operator to avoid calling v8::Undefined when it's not needed?

[alecflett, 2013/08/13 20:37:11]

Doing that now - I see why it was done the other way elsewhere though - note the
explicit casting on v8::Undefined.

+
+        ScriptValue result = function->call(ScriptValue(value));
+        v8SetReturnValue(args, result.v8Value());
+    }
+
+    ScopedPersistent<v8::Function> m_function;
+    friend class RefCounted<ScriptFunction>;
 };
 
 } // namespace WebCore
 
 #endif