chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc - Issue 22470007: Add a "key" entry to InstallWarnings, remove InstallWarning::Format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

Issue 22470007: Add a "key" entry to InstallWarnings, remove InstallWarning::Format (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_infrastructure

Patch Set: Reordered params Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/script_badge_handler.cc ('k') | chrome/common/extensions/extension_file_util.h » ('j') | extensions/common/install_warning.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

index e4258cc4bc184c72ecb75c56db732fa88666c2ef..887a9ec163004d711d41b18cec2f6e7392457ba9 100644

--- a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

@@ -14,6 +14,7 @@

#include "testing/gtest/include/gtest/gtest.h"

namespace errors = extension_manifest_errors;

+namespace keys = extension_manifest_keys;

namespace extensions {

@@ -98,10 +99,10 @@ TEST_F(ScriptBadgeManifestTest, ScriptBadgeExplicitTitleAndIconsIgnored) {

EXPECT_THAT(StripMissingFlagWarning(extension->install_warnings()),

testing::ElementsAre(

- InstallWarning(InstallWarning::FORMAT_TEXT,

- errors::kScriptBadgeTitleIgnored),

- InstallWarning(InstallWarning::FORMAT_TEXT,

- errors::kScriptBadgeIconIgnored)));

+ InstallWarning(errors::kScriptBadgeTitleIgnored,

+ keys::kScriptBadge),

+ InstallWarning(errors::kScriptBadgeIconIgnored,

+ keys::kScriptBadge)));

const ExtensionIconSet& default_icon =

script_badge_info->default_icon;