chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 22470007: Add a "key" entry to InstallWarnings, remove InstallWarning::Format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 22470007: Add a "key" entry to InstallWarnings, remove InstallWarning::Format (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_infrastructure

Patch Set: Reordered params Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index b12a16c18cda6b939c08825590c55d724838f150..27c2e9fdff6c40660e970c4524a51449cd91e4a6 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -304,7 +304,6 @@ scoped_ptr<developer::ItemInfo>

item.install_warnings().begin();

it != item.install_warnings().end(); ++it) {

developer::InstallWarning* warning = new developer::InstallWarning();

- warning->is_html = (it->format == InstallWarning::FORMAT_HTML);

warning->message = it->message;

info->install_warnings.push_back(make_linked_ptr(warning));

}

« no previous file with comments | « no previous file | chrome/browser/resources/apps_debugger/js/items_list.js » ('j') | extensions/common/install_warning.h » ('J')