chrome/common/extensions/permissions/permissions_data.cc - Issue 22470007: Add a "key" entry to InstallWarnings, remove InstallWarning::Format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permissions_data.cc

Issue 22470007: Add a "key" entry to InstallWarnings, remove InstallWarning::Format (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_infrastructure

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/externally_connectable.cc ('k') | extensions/common/install_warning.h » ('j') | extensions/common/install_warning.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/permissions_data.cc

diff --git a/chrome/common/extensions/permissions/permissions_data.cc b/chrome/common/extensions/permissions/permissions_data.cc

index 8b5796ebf53178d3023273befd1be67cf677f4d7..0de2e6d8623f6c65a85413bb45ff462e55994fd2 100644

--- a/chrome/common/extensions/permissions/permissions_data.cc

+++ b/chrome/common/extensions/permissions/permissions_data.cc

@@ -157,7 +157,7 @@ bool ParseHelper(Extension* extension,

// Don't fail, but warn the developer that the manifest contains

// unrecognized permissions. This may happen legitimately if the

// extensions requests platform- or channel-specific permissions.

- extension->AddInstallWarning(InstallWarning(InstallWarning::FORMAT_TEXT,

+ extension->AddInstallWarning(InstallWarning(feature->name(),

availability.message()));

to_remove.push_back(iter->id());

continue;

@@ -231,7 +231,8 @@ bool ParseHelper(Extension* extension,

// It's probably an unknown API permission. Do not throw an error so

// extensions can retain backwards compatability (http://crbug.com/42742).

extension->AddInstallWarning(InstallWarning(

- InstallWarning::FORMAT_TEXT,

+ key,

+ permission_str,

base::StringPrintf(

"Permission '%s' is unknown or URL pattern is malformed.",

permission_str.c_str())));