Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/browser/resources/apps_debugger/js/items_list.js

Issue 22470007: Add a "key" entry to InstallWarnings, remove InstallWarning::Format (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_infrastructure
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('apps_dev_tool', function() { 5 cr.define('apps_dev_tool', function() {
6 'use strict'; 6 'use strict';
7 7
8 // The list of all packed/unpacked apps and extensions. 8 // The list of all packed/unpacked apps and extensions.
9 var completeList = []; 9 var completeList = [];
10 10
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 if (!item.may_disable) 280 if (!item.may_disable)
281 node.querySelector('.managed-message').hidden = false; 281 node.querySelector('.managed-message').hidden = false;
282 282
283 // The install warnings. 283 // The install warnings.
284 if (item.install_warnings.length > 0) { 284 if (item.install_warnings.length > 0) {
285 var panel = node.querySelector('.install-warnings'); 285 var panel = node.querySelector('.install-warnings');
286 panel.hidden = false; 286 panel.hidden = false;
287 var list = panel.querySelector('ul'); 287 var list = panel.querySelector('ul');
288 item.install_warnings.forEach(function(warning) { 288 item.install_warnings.forEach(function(warning) {
289 var li = document.createElement('li'); 289 var li = document.createElement('li');
290 li[warning.isHTML ? 'innerHTML' : 'textContent'] = warning.message; 290 li.textContent = warning.message;
291 list.appendChild(li); 291 list.appendChild(li);
292 }); 292 });
293 } 293 }
294 294
295 this.setActiveViews_(item, node); 295 this.setActiveViews_(item, node);
296 296
297 return node; 297 return node;
298 }, 298 },
299 299
300 /** 300 /**
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
599 // node. 599 // node.
600 container.scrollTop = node.offsetTop + node.offsetHeight - 600 container.scrollTop = node.offsetTop + node.offsetHeight -
601 container.offsetHeight + 20; 601 container.offsetHeight + 20;
602 } 602 }
603 }; 603 };
604 604
605 return { 605 return {
606 ItemsList: ItemsList, 606 ItemsList: ItemsList,
607 }; 607 };
608 }); 608 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698