Add a "key" entry to InstallWarnings, remove InstallWarning::Format

Add a "key" entry to InstallWarnings, remove InstallWarning::Format

Add a "key" entry to InstallWarnings to provide information about where in the
manifest we found the warning (this will be used to highlight the line in
question with the error console).

Remove InstallWarning::Format, since there is never an instance of
InstallWarning::HTML (so far as I can find).

In preparation for https://codereview.chromium.org/22938005/

BUG=21734
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217847

[Yoyo Zhou, 2013-08-14 22:40:36]

https://codereview.chromium.org/22470007/diff/18001/extensions/common/install...
File extensions/common/install_warning.h (right):

https://codereview.chromium.org/22470007/diff/18001/extensions/common/install...
extensions/common/install_warning.h:15: InstallWarning(const std::string& key,
This is slightly unintuitive. Usually when you allow arguments to be omitted,
you have
1
12
123
but here it's
3
13
123
Why not make message the first argument?

https://codereview.chromium.org/22470007/diff/18001/extensions/common/install...
extensions/common/install_warning.h:23: return message == other.message;
Maybe comment why this is appropriate and we can ignore key/specific.

https://codereview.chromium.org/22470007/diff/18001/extensions/common/install...
extensions/common/install_warning.h:26: // The manifest key to which this
warning pertains (e.g., 'permissions').
This is also optional, right?

[Devlin, 2013-08-15 00:20:25]

https://codereview.chromium.org/22470007/diff/18001/extensions/common/install...
File extensions/common/install_warning.h (right):

https://codereview.chromium.org/22470007/diff/18001/extensions/common/install...
extensions/common/install_warning.h:15: InstallWarning(const std::string& key,
On 2013/08/14 22:40:36, Yoyo Zhou wrote:
> This is slightly unintuitive. Usually when you allow arguments to be omitted,
> you have
> 1
> 12
> 123
> but here it's
> 3
> 13
> 123
> Why not make message the first argument?

Done.

https://codereview.chromium.org/22470007/diff/18001/extensions/common/install...
extensions/common/install_warning.h:23: return message == other.message;
On 2013/08/14 22:40:36, Yoyo Zhou wrote:
> Maybe comment why this is appropriate and we can ignore key/specific.

Done.

https://codereview.chromium.org/22470007/diff/18001/extensions/common/install...
extensions/common/install_warning.h:26: // The manifest key to which this
warning pertains (e.g., 'permissions').
On 2013/08/14 22:40:36, Yoyo Zhou wrote:
> This is also optional, right?

Done.

[Yoyo Zhou, 2013-08-15 00:25:13]

LGTM

https://codereview.chromium.org/22470007/diff/31001/extensions/common/install...
File extensions/common/install_warning.h (right):

https://codereview.chromium.org/22470007/diff/31001/extensions/common/install...
extensions/common/install_warning.h:29: // "foo", but these are reduntant with
the message.
redundant

https://codereview.chromium.org/22470007/diff/31001/extensions/common/install...
extensions/common/install_warning.h:36: // Optional, as not all warnings need to
pertain to a particular key
I don't think you need to explain why these fields are optional, but it would be
nice to say why we have them at all - "for highlighting the incorrect key in the
error console view" or whatever.

[Devlin, 2013-08-15 16:54:16]

https://codereview.chromium.org/22470007/diff/31001/extensions/common/install...
File extensions/common/install_warning.h (right):

https://codereview.chromium.org/22470007/diff/31001/extensions/common/install...
extensions/common/install_warning.h:29: // "foo", but these are reduntant with
the message.
On 2013/08/15 00:25:13, Yoyo Zhou wrote:
> redundant

Done.

https://codereview.chromium.org/22470007/diff/31001/extensions/common/install...
extensions/common/install_warning.h:36: // Optional, as not all warnings need to
pertain to a particular key
On 2013/08/15 00:25:13, Yoyo Zhou wrote:
> I don't think you need to explain why these fields are optional, but it would
be
> nice to say why we have them at all - "for highlighting the incorrect key in
the
> error console view" or whatever.

Done.

[Devlin, 2013-08-15 16:55:08]

+dbeam for c/b/resources/ and c/b/ui/webui

[Dan Beam, 2013-08-15 17:00:32]

lgtm

[commit-bot: I haz the power, 2013-08-15 17:05:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/22470007/3...

[commit-bot: I haz the power, 2013-08-15 18:08:22]

Retried try job too often on mac_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-08-15 19:22:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/22470007/3...

[commit-bot: I haz the power, 2013-08-15 22:04:37]

Change committed as 217847