[SVGDom] Add opacity support

[SVGDom] Add opacity support

Group opacity support.  Unlike the other presentation attributes we
support thus far, group opacity is not inherited.

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246943002

Committed: https://skia.googlesource.com/skia/+/6fb0648c35aead138e65133c031d2b4fe5c8f0c7

[f(malita), 2016-08-15 17:15:14]

Description was changed from

==========
[SVGDom] Add opacity support

Group opacity support.  Unlike the other presentation attributes we
support thus far, group opacity is not inherited.

R=robertphillips@google.com,stephana@google.com
==========

to

==========
[SVGDom] Add opacity support

Group opacity support.  Unlike the other presentation attributes we
support thus far, group opacity is not inherited.

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246943002
==========

[f(malita), 2016-08-15 17:17:18]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 17:17:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 17:26:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 17:26:55]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[robertphillips, 2016-08-15 17:31:27]

https://codereview.chromium.org/2246943002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2246943002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRenderContext.cpp:233: fCanvas->saveLayer(nullptr,
&opacityPaint);
Where is the matching restore ?

[f(malita), 2016-08-15 17:33:58]

https://codereview.chromium.org/2246943002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2246943002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRenderContext.cpp:233: fCanvas->saveLayer(nullptr,
&opacityPaint);
On 2016/08/15 17:31:27, robertphillips wrote:
> Where is the matching restore ?

SkSVGRenderContext is node-scoped and always restores to the initial save count
- see destructor just above this method.

[robertphillips, 2016-08-15 17:37:54]

lgtm

https://codereview.chromium.org/2246943002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2246943002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRenderContext.cpp:233: fCanvas->saveLayer(nullptr,
&opacityPaint);
On 2016/08/15 17:33:58, f(malita) wrote:
> On 2016/08/15 17:31:27, robertphillips wrote:
> > Where is the matching restore ?
> 
> SkSVGRenderContext is node-scoped and always restores to the initial save
count
> - see destructor just above this method.

Ah - okay. Can you add that as a comment? It wasn't immediately obvious to me.

[f(malita), 2016-08-15 17:41:23]

https://codereview.chromium.org/2246943002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2246943002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRenderContext.cpp:233: fCanvas->saveLayer(nullptr,
&opacityPaint);
On 2016/08/15 17:37:54, robertphillips wrote:
> On 2016/08/15 17:33:58, f(malita) wrote:
> > On 2016/08/15 17:31:27, robertphillips wrote:
> > > Where is the matching restore ?
> > 
> > SkSVGRenderContext is node-scoped and always restores to the initial save
> count
> > - see destructor just above this method.
> 
> Ah - okay. Can you add that as a comment? It wasn't immediately obvious to me.

Done.

[f(malita), 2016-08-15 17:41:28]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 17:41:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 17:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 17:54:22]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[f(malita), 2016-08-15 19:16:01]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-08-15 19:16:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2246943002/#ps40001
(title: "pic/serialize blacklist")

[commit-bot: I haz the power, 2016-08-15 19:16:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-08-15 19:41:47]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-08-15 19:41:48]

Have you run

$ python infra/bots/recipes.py simulation_test train

?

[commit-bot: I haz the power, 2016-08-15 19:45:15]

Description was changed from

==========
[SVGDom] Add opacity support

Group opacity support.  Unlike the other presentation attributes we
support thus far, group opacity is not inherited.

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246943002
==========

to

==========
[SVGDom] Add opacity support

Group opacity support.  Unlike the other presentation attributes we
support thus far, group opacity is not inherited.

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246943002

Committed:
https://skia.googlesource.com/skia/+/6fb0648c35aead138e65133c031d2b4fe5c8f0c7
==========

[commit-bot: I haz the power, 2016-08-15 19:45:17]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6fb0648c35aead138e65133c031d2b4fe5c8f0c7