Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2246923006: Show no fractions for JPY currency. (Closed)

Created:
4 years, 4 months ago by please use gerrit instead
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show no fractions for JPY currency. Currencies such as JPY do not have fractions by default. If the website is using web payments with an amount like "500", then UI should show only "500", without any decimals. BUG=638480 Committed: https://crrev.com/f36dc088ea31d9385246dbe67a82505acb56c410 Cr-Commit-Position: refs/heads/master@{#412562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyStringFormatter.java View 4 chunks +23 lines, -11 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
please use gerrit instead
dfalcantara, ptal.
4 years, 4 months ago (2016-08-17 05:54:27 UTC) #7
gone
lgtm
4 years, 4 months ago (2016-08-17 16:29:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246923006/1
4 years, 4 months ago (2016-08-17 16:41:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 16:51:21 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 16:53:06 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f36dc088ea31d9385246dbe67a82505acb56c410
Cr-Commit-Position: refs/heads/master@{#412562}

Powered by Google App Engine
This is Rietveld 408576698