Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2246923003: Avoid integer overflow in WheelEvent constructor (Closed)

Created:
4 years, 4 months ago by bashi
Modified:
4 years, 4 months ago
Reviewers:
Yuta Kitamura, yhirano, tzik
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid integer overflow in WheelEvent constructor Don't negate when long values are LONG_MIN BUG=634794 Committed: https://crrev.com/f352827c452f7d6b493cd03cc367221368912879 Cr-Commit-Position: refs/heads/master@{#412194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/Source/core/events/WheelEvent.cpp View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
bashi
PTAL Chose this fix to keep the same behavior in tests.
4 years, 4 months ago (2016-08-16 07:14:49 UTC) #4
tzik
lgtm
4 years, 4 months ago (2016-08-16 07:26:48 UTC) #5
Yuta Kitamura
lgtm
4 years, 4 months ago (2016-08-16 07:26:51 UTC) #6
bashi
(Adding more context) I tried casting values to double as yhirano@ suggested (thanks for the ...
4 years, 4 months ago (2016-08-16 07:29:42 UTC) #8
yhirano
lgtm
4 years, 4 months ago (2016-08-16 08:29:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246923003/1
4 years, 4 months ago (2016-08-16 08:40:07 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 08:43:33 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 08:45:11 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f352827c452f7d6b493cd03cc367221368912879
Cr-Commit-Position: refs/heads/master@{#412194}

Powered by Google App Engine
This is Rietveld 408576698