chrome/browser/media/window_icon_util.h - Issue 2246923002: Icon Capture Utility For Linux, Windows and Mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/window_icon_util.h

Issue 2246923002: Icon Capture Utility For Linux, Windows and Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_MEDIA_WINDOW_ICON_UTIL_H_

	6 #define CHROME_BROWSER_MEDIA_WINDOW_ICON_UTIL_H_

	7

	8 #include "content/public/browser/desktop_media_id.h"

	9 #include "third_party/webrtc/modules/desktop_capture/desktop_capture_options.h"

	10 #include "ui/gfx/image/image_skia.h"

	11

	12 class WindowIconUtil {

	13 public:

	14 virtual gfx::ImageSkia GetWindowIcon(content::DesktopMediaID id) = 0;

	15

	16 static std::unique_ptr<WindowIconUtil> Create(

	17 const webrtc::DesktopCaptureOptions& options);
	Sergey Ulanov 2016/08/15 22:28:39 I don't think there is any reason to depend on web I don't think there is any reason to depend on webrtc::DesktopCaptureOptions here. You are currently use it to pass X11 connection to the X11 version of the capturer. It would be cleaner to just reuse the X11 connection that chrome already has, i.e. gfx::GetXDisplay(). Then you wouldn't even need this as an interface, and instead you would have a simple function that returns a window icon.. qiangchen 2016/08/16 22:29:52 Done. Show quoted text On 2016/08/15 22:28:39, Sergey Ulanov wrote: > I don't think there is any reason to depend on webrtc::DesktopCaptureOptions > here. You are currently use it to pass X11 connection to the X11 version of the > capturer. It would be cleaner to just reuse the X11 connection that chrome > already has, i.e. gfx::GetXDisplay(). Then you wouldn't even need this as an > interface, and instead you would have a simple function that returns a window > icon.. Done.
	18 };

	19

	20 #endif // CHROME_BROWSER_MEDIA_WINDOW_ICON_UTIL_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/media/window_icon_util_mac.mm » ('j') | chrome/browser/media/window_icon_util_win.cc » ('J')