add parallel public API for recording SkLiteDL.

add parallel public API for recording SkLiteDL.

The API is restricted to pretty much just what Derek calls,
but it's enough that we can switch testing over to use it.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246893002

Committed: https://skia.googlesource.com/skia/+/ced26a3d6b77d3a6744a8ccb8eff23eda45fc867

[mtklein_C, 2016-08-15 14:41:10]

Description was changed from

==========
add parallel public API for recording SkLiteDL.

The API is restricted to pretty much just what Derek calls.

BUG=skia:
==========

to

==========
add parallel public API for recording SkLiteDL.

The API is restricted to pretty much just what Derek calls.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246893002
==========

[mtklein_C, 2016-08-15 14:41:15]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 14:41:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-15 14:41:32]

Description was changed from

==========
add parallel public API for recording SkLiteDL.

The API is restricted to pretty much just what Derek calls.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246893002
==========

to

==========
add parallel public API for recording SkLiteDL.

The API is restricted to pretty much just what Derek calls,
but it's enough that we can switch testing over to use it.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246893002
==========

[mtklein_C, 2016-08-15 14:43:52]

mtklein@chromium.org changed reviewers:
+ djsollen@google.com

[djsollen, 2016-08-15 14:47:43]

https://codereview.chromium.org/2246893002/diff/1/include/core/SkPictureRecor...
File include/core/SkPictureRecorder.h (right):

https://codereview.chromium.org/2246893002/diff/1/include/core/SkPictureRecor...
include/core/SkPictureRecorder.h:161: sk_sp<SkDrawable>
finishRecordingAsDrawable(uint32_t ignored = 0);
will this return a nullptr if there were no drawing ops?

[mtklein, 2016-08-15 14:54:39]

On 2016/08/15 14:47:43, djsollen wrote:
>
https://codereview.chromium.org/2246893002/diff/1/include/core/SkPictureRecor...
> File include/core/SkPictureRecorder.h (right):
> 
>
https://codereview.chromium.org/2246893002/diff/1/include/core/SkPictureRecor...
> include/core/SkPictureRecorder.h:161: sk_sp<SkDrawable>
> finishRecordingAsDrawable(uint32_t ignored = 0);
> will this return a nullptr if there were no drawing ops?

no.  is that important?

[djsollen, 2016-08-15 15:00:48]

lgtm

[commit-bot: I haz the power, 2016-08-15 15:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 15:03:45]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-08-15 15:04:34]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-08-15 15:04:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 15:05:41]

Description was changed from

==========
add parallel public API for recording SkLiteDL.

The API is restricted to pretty much just what Derek calls,
but it's enough that we can switch testing over to use it.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246893002
==========

to

==========
add parallel public API for recording SkLiteDL.

The API is restricted to pretty much just what Derek calls,
but it's enough that we can switch testing over to use it.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246893002

Committed:
https://skia.googlesource.com/skia/+/ced26a3d6b77d3a6744a8ccb8eff23eda45fc867
==========

[commit-bot: I haz the power, 2016-08-15 15:05:42]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ced26a3d6b77d3a6744a8ccb8eff23eda45fc867

[reed1, 2016-08-15 15:52:51]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-08-15 15:52:51]

https://codereview.chromium.org/2246893002/diff/1/include/core/SkPictureRecor...
File include/core/SkPictureRecorder.h (right):

https://codereview.chromium.org/2246893002/diff/1/include/core/SkPictureRecor...
include/core/SkPictureRecorder.h:143: class SkLiteDL;
Perhaps we can make this a separate file for now, so it stays more hidden until
it is baked.

[mtklein, 2016-08-15 19:55:51]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2243393002/ by mtklein@google.com.

The reason for reverting is: looking like we won't need this.