content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java - Issue 2246833002: Ignore reentrancy for ImeThread triggering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

Issue 2246833002: Ignore reentrancy for ImeThread triggering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed scope and fixed nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

index 2bad1d3df4d8ee9bdea312192c4f82299f38fb4a..a7e5661331b1ba5929c9ead5a037027049d4ffba 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

@@ -13,7 +13,6 @@ import android.view.View;

import android.view.inputmethod.BaseInputConnection;

import android.view.inputmethod.CompletionInfo;

import android.view.inputmethod.CorrectionInfo;

-import android.view.inputmethod.EditorInfo;

import android.view.inputmethod.ExtractedText;

import android.view.inputmethod.ExtractedTextRequest;

import android.view.inputmethod.InputConnection;

@@ -106,15 +105,10 @@ public class ThreadedInputConnection extends BaseInputConnection

mHandler = handler;

}

- void initializeOutAttrsOnUiThread(int inputType, int inputFlags, int selectionStart,

- int selectionEnd, EditorInfo outAttrs) {

+ void resetOnUiThread() {

ImeUtils.checkOnUiThread();

mNumNestedBatchEdits = 0;

mPendingAccent = 0;

- ImeUtils.computeEditorInfo(inputType, inputFlags, selectionStart, selectionEnd, outAttrs);

- if (DEBUG_LOGS) {

- Log.w(TAG, "initializeOutAttrs: " + ImeUtils.getEditorInfoDebugString(outAttrs));

- }

}

@Override