Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2246803002: Exclude elements with overflow-anchor:none from anchor node selection (Closed)

Created:
4 years, 4 months ago by ymalik
Modified:
4 years, 4 months ago
Reviewers:
skobes
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, ojan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude elements with overflow-anchor:none from anchor node selection BUG=635716 Committed: https://crrev.com/82a6ae9efa7fa7f60d9af62bd2b3f2ebe023e177 Cr-Commit-Position: refs/heads/master@{#412035}

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/ScrollAnchor.cpp View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ymalik
4 years, 4 months ago (2016-08-15 01:09:37 UTC) #2
skobes
lgtm I think this is ok to land for now; we can switch to a ...
4 years, 4 months ago (2016-08-15 18:51:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246803002/20001
4 years, 4 months ago (2016-08-15 19:09:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 20:33:11 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 20:45:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82a6ae9efa7fa7f60d9af62bd2b3f2ebe023e177
Cr-Commit-Position: refs/heads/master@{#412035}

Powered by Google App Engine
This is Rietveld 408576698