Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2246773002:
Run blimp_unittests on Blimp engine buildbot (Closed)
|
Created:
4 years, 4 months ago by Brian Goldman Modified:
4 years, 4 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionblimp_linux_dbg is currently configured to just run blimp_browsertests. Add blimp_unittests.
BUG=637613
Committed: https://crrev.com/b578c2df9a3b58470b15b646f0b9acb9b47fa41a
Cr-Commit-Position: refs/heads/master@{#412404}
Patch Set 1 #
Messages
Total messages: 20 (15 generated)
The CQ bit was checked by bgoldman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== wip BUG= ========== to ========== BUG=637613 ==========
The CQ bit was checked by bgoldman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== BUG=637613 ========== to ========== blimp_linux_dbg is currently configured to just run blimp_browertests. Add blimp_unittests. BUG=637613 ==========
bgoldman@chromium.org changed reviewers: + dpranke@chromium.org
Description was changed from ========== blimp_linux_dbg is currently configured to just run blimp_browertests. Add blimp_unittests. BUG=637613 ========== to ========== blimp_linux_dbg is currently configured to just run blimp_browsertests. Add blimp_unittests. BUG=637613 ==========
lgtm
The CQ bit was checked by bgoldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== blimp_linux_dbg is currently configured to just run blimp_browsertests. Add blimp_unittests. BUG=637613 ========== to ========== blimp_linux_dbg is currently configured to just run blimp_browsertests. Add blimp_unittests. BUG=637613 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== blimp_linux_dbg is currently configured to just run blimp_browsertests. Add blimp_unittests. BUG=637613 ========== to ========== blimp_linux_dbg is currently configured to just run blimp_browsertests. Add blimp_unittests. BUG=637613 Committed: https://crrev.com/b578c2df9a3b58470b15b646f0b9acb9b47fa41a Cr-Commit-Position: refs/heads/master@{#412404} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b578c2df9a3b58470b15b646f0b9acb9b47fa41a Cr-Commit-Position: refs/heads/master@{#412404} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
