Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 224673002: Removes "copy" action for extra_native_libs in java_apk.gypi. (Closed)

Created:
6 years, 8 months ago by gunsch
Modified:
6 years, 8 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, chz, byungchul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removes "copy" action for extra_native_libs in java_apk.gypi. Since the output lib file is already generated by strip_native_libraries, the 'copy' action will result in the unstripped version overwriting the stripped one and getting packaged in the final APK. Before change: $ ninja -C out/Debug -j32 content_shell_apk [snipped] $ ls -l out/Debug/apks/ContentShell.apk -rw-r----- 1 gunsch eng 27M Apr 3 15:09 out/Debug/apks/ContentShell.apk $ unzip -l out/Debug/apks/ContentShell.apk | grep lib/ 264772 2014-04-03 14:54 lib/armeabi-v7a/gdbserver 16030344 2014-04-03 15:00 lib/armeabi-v7a/libosmesa.so 38423836 2014-04-03 15:09 lib/armeabi-v7a/libcontent_shell_content_view.so $ ls -l out/Debug/lib total 2.2G -rwxr-x--- 1 gunsch eng 2.2G Apr 3 15:09 libcontent_shell_content_view.so -rw-r----- 1 gunsch eng 5.7K Apr 3 15:09 libcontent_shell_content_view.so.TOC -rwxr-x--- 1 gunsch eng 26K Mar 28 14:25 libmojo_system.so -rw-r----- 1 gunsch eng 714 Mar 28 14:25 libmojo_system.so.TOC -rwxr-x--- 2 gunsch eng 16M Apr 3 15:00 libosmesa.so $ ls -l out/Debug/content_shell_apk/libs/armeabi-v7a/ total 53M -rwxr-x--- 2 gunsch eng 259K Apr 3 14:54 gdbserver -rwxr-x--- 1 gunsch eng 37M Apr 3 15:09 libcontent_shell_content_view.so -rwxr-x--- 2 gunsch eng 16M Apr 3 15:00 libosmesa.so After change: $ ls -l out/Debug/apks/ContentShell.apk -rw-r----- 1 gunsch eng 21M Apr 3 15:31 out/Debug/apks/ContentShell.apk $ unzip -l out/Debug/apks/ContentShell.apk | grep lib/ 264772 2014-04-03 14:54 lib/armeabi-v7a/gdbserver 2289816 2014-04-03 15:31 lib/armeabi-v7a/libosmesa.so 38423836 2014-04-03 15:31 lib/armeabi-v7a/libcontent_shell_content_view.so $ ls -l out/Debug/lib total 2.2G -rwxr-x--- 1 gunsch eng 2.2G Apr 3 15:31 libcontent_shell_content_view.so -rw-r----- 1 gunsch eng 5.7K Apr 3 15:31 libcontent_shell_content_view.so.TOC -rwxr-x--- 1 gunsch eng 16M Apr 3 15:30 libosmesa.so $ ls -l out/Debug/content_shell_apk/libs/armeabi-v7a/ total 40M -rwxr-x--- 2 gunsch eng 259K Apr 3 14:54 gdbserver -rwxr-x--- 1 gunsch eng 37M Apr 3 15:31 libcontent_shell_content_view.so -rwxr-x--- 1 gunsch eng 2.2M Apr 3 15:31 libosmesa.so BUG= R=peter@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/java_apk.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
gunsch
6 years, 8 months ago (2014-04-03 22:44:21 UTC) #1
Peter Beverloo
lgtm, thanks for doing this!
6 years, 8 months ago (2014-04-08 12:50:16 UTC) #2
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 8 months ago (2014-04-08 15:38:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/224673002/1
6 years, 8 months ago (2014-04-08 15:38:14 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 18:39:57 UTC) #5
Message was sent while issue was closed.
Change committed as 262461

Powered by Google App Engine
This is Rietveld 408576698