LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin.html - Issue 22467005: Correctly attribute exceptions thrown inside a Worker's imported scripts.

Side by Side Diff: LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin.html

Issue 22467005: Correctly attribute exceptions thrown inside a Worker's imported scripts. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/http/tests/workers/worker-importScripts-expected.txt ('k') | LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin-expected.txt » ('j') | Source/bindings/v8/WorkerScriptController.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script>	4 <script>

5 window.jsTestIsAsync = true;	5 window.jsTestIsAsync = true;

6 window.isOnErrorTest = true;	6 window.isOnErrorTest = true;

7 </script>	7 </script>

8 <script src="/resources/js-test-pre.js"></script>	8 <script src="/resources/js-test-pre.js"></script>

9 <script src="/resources/js-test-post.js"></script>	9 <script src="/resources/js-test-post.js"></script>

10 </head>	10 </head>

11 <body>	11 <body>

12 <script>	12 <script>

13 description("Ensure that scripts imported into a Worker from cross-origi n hosts trigger sanitized onerror messages.");	13 description("Ensure that scripts imported into a Worker from cross-origi n hosts trigger sanitized onerror messages.");

14	14

15 var worker = new Worker('resources/worker-importscripts-onerror-crossori gin.js');	15 var worker = new Worker('resources/worker-importscripts-onerror-crossori gin.js');

16	16

17 var workerOnerror;	17 var workerOnerror, pageOnerror;

18 worker.onmessage = function (e) {	18 worker.onmessage = function (e) {

19 workerOnerror = e.data;	19 workerOnerror = e.data;

20 shouldBeEqualToString("workerOnerror.message", "Uncaught undefined") ;	20 shouldBeEqualToString("workerOnerror.message", "Script error.");

21 shouldBeEqualToString("workerOnerror.filename", "http://127.0.0.1:80 00/workers/resources/worker-importscripts-onerror-crossorigin.js");	21 shouldBeEqualToString("workerOnerror.filename", "");

22 shouldEvaluateTo("workerOnerror.lineno", 5);	22 shouldEvaluateTo("workerOnerror.lineno", 0);

23 shouldEvaluateTo("workerOnerror.column", 0);	23 shouldEvaluateTo("workerOnerror.column", 0);
	do-not-use 2013/08/07 18:05:05 It looks a bit weird to have lineno / column, espe It looks a bit weird to have lineno / column, especially now that the spec was updated. Mike West 2013/08/08 05:03:15 Good point. I'll update these. Show quoted text On 2013/08/07 18:05:05, Christophe Dumez wrote: > It looks a bit weird to have lineno / column, especially now that the spec was > updated. Good point. I'll update these.
	24 shouldBeNull("workerOnerror.error");

24 };	25 };

25	26

26 var onerrorMessage, onerrorURL, onerrorLine;	27 var onerrorMessage, onerrorURL, onerrorLine;

27 worker.onerror = function (e) {	28 worker.onerror = function (e) {

28 onerrorMessage = e.message;	29 pageOnerror = e;

29 onerrorURL = e.filename;	30 shouldBeEqualToString("pageOnerror.message", "Script error.");

30 onerrorLine = e.lineno;	31 shouldBeEqualToString("pageOnerror.filename", "");

31 shouldBeEqualToString("onerrorMessage", "Uncaught undefined");	32 shouldEvaluateTo("pageOnerror.lineno", 0);

32 shouldBeEqualToString("onerrorURL", "http://127.0.0.1:8000/workers/r esources/worker-importscripts-onerror-crossorigin.js");	33 shouldEvaluateTo("pageOnerror.colno", 0);

33 shouldEvaluateTo("onerrorLine", 5);	34 shouldBeNull("pageOnerror.error");

34	35

35 e.preventDefault();	36 e.preventDefault();

36 finishJSTest();	37 finishJSTest();

37 };	38 };

38 </script>	39 </script>

39 </body>	40 </body>

40 </html>	41 </html>

OLD	NEW