Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2246673002: [ios] Made web_main_runner.h header public. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Made web_main_runner.h header public. content_main_runner.h is public, so web_main_runner.h should be public as well. BUG=616247 Committed: https://crrev.com/35959165ff95dfedb35e78c586f2c014ccdeb84c Cr-Commit-Position: refs/heads/master@{#411989}

Patch Set 1 #

Patch Set 2 : Fixed gn #

Patch Set 3 : Added missing file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -27 lines) Patch
M ios/web/app/web_main.mm View 1 chunk +1 line, -1 line 0 comments Download
D ios/web/app/web_main_runner.h View 1 2 1 chunk +4 lines, -20 lines 0 comments Download
M ios/web/app/web_main_runner.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/ios_web.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/public/app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + ios/web/public/app/web_main_runner.h View 1 2 2 chunks +3 lines, -3 lines 2 comments Download

Messages

Total messages: 17 (11 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-08-12 23:17:21 UTC) #3
Jackie Quinn
lgtm w/ date swap https://codereview.chromium.org/2246673002/diff/40001/ios/web/public/app/web_main_runner.h File ios/web/public/app/web_main_runner.h (right): https://codereview.chromium.org/2246673002/diff/40001/ios/web/public/app/web_main_runner.h#newcode1 ios/web/public/app/web_main_runner.h:1: // Copyright 2014 The Chromium ...
4 years, 4 months ago (2016-08-15 17:30:22 UTC) #9
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/2246673002/diff/40001/ios/web/public/app/web_main_runner.h File ios/web/public/app/web_main_runner.h (right): https://codereview.chromium.org/2246673002/diff/40001/ios/web/public/app/web_main_runner.h#newcode1 ios/web/public/app/web_main_runner.h:1: // Copyright 2014 The Chromium Authors. All rights ...
4 years, 4 months ago (2016-08-15 18:11:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246673002/40001
4 years, 4 months ago (2016-08-15 18:12:03 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-15 18:17:33 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 18:19:07 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/35959165ff95dfedb35e78c586f2c014ccdeb84c
Cr-Commit-Position: refs/heads/master@{#411989}

Powered by Google App Engine
This is Rietveld 408576698