Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2246613002:
Fix jank during mac resize (Closed)
|
Created:
4 years, 4 months ago by enne (OOO) Modified:
4 years, 4 months ago CC:
ccameron, chromium-reviews, darin-cc_chromium.org, jam, no sievers Base URL:
https://chromium.googlesource.com/chromium/src.git@fixhangoutsblank Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix jank during mac resize
Allow SetNeedsBeginFrames messages to be handled on Mac during resize.
If this message is not handled, then the renderer says that it needs
frames but the message is ignored because of the resize lock. Then, the
browser never sends begin frame messages and the renderer then never is
able to produce a frame. This means that it can't produce a frame of
the right size before the resize lock times out and there's jank on
screen.
R=ccameron@chromium.org,sievers@chromium.org
BUG=632603, 638561
Committed: https://crrev.com/e5ce61d4966237e3572f3048a6ea39c7ba7d7c64
Cr-Commit-Position: refs/heads/master@{#413601}
Patch Set 1 #Patch Set 2 : Allow SetNeedsBeginFrames during resize #Patch Set 3 : Fix flash video #
Messages
Total messages: 30 (18 generated)
enne@chromium.org changed reviewers: + asvitkine@chromium.org - ccameron@chromium.org, sievers@chromium.org
Description was changed from ========== Fix jank during mac resize R=ccameron@chromium.org,sievers@chromium.org BUG=632603 ========== to ========== Fix jank during mac resize Allow SetNeedsBeginFrames messages to be handled on Mac during resize. If this message is not handled, then the renderer says that it needs frames but the message is ignored because of the resize lock. Then, the browser never sends begin frame messages and the renderer then never is able to produce a frame. This means that it can't produce a frame of the right size before the resize lock times out and there's jank on screen. R=ccameron@chromium.org,sievers@chromium.org BUG=632603 ==========
The CQ bit was checked by enne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ccameron@chromium.org changed reviewers: + ccameron@chromium.org
lgtm
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by enne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix jank during mac resize Allow SetNeedsBeginFrames messages to be handled on Mac during resize. If this message is not handled, then the renderer says that it needs frames but the message is ignored because of the resize lock. Then, the browser never sends begin frame messages and the renderer then never is able to produce a frame. This means that it can't produce a frame of the right size before the resize lock times out and there's jank on screen. R=ccameron@chromium.org,sievers@chromium.org BUG=632603 ========== to ========== Fix jank during mac resize Allow SetNeedsBeginFrames messages to be handled on Mac during resize. If this message is not handled, then the renderer says that it needs frames but the message is ignored because of the resize lock. Then, the browser never sends begin frame messages and the renderer then never is able to produce a frame. This means that it can't produce a frame of the right size before the resize lock times out and there's jank on screen. R=ccameron@chromium.org,sievers@chromium.org BUG=632603 Committed: https://crrev.com/ee0504e307d6ed18a94a96eae8a4b57adcff4b11 Cr-Commit-Position: refs/heads/master@{#411806} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ee0504e307d6ed18a94a96eae8a4b57adcff4b11 Cr-Commit-Position: refs/heads/master@{#411806}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2255893002/ by enne@chromium.org. The reason for reverting is: Causes fullscreen flash videos to be all white on Mac BUG=638561.
Description was changed from ========== Fix jank during mac resize Allow SetNeedsBeginFrames messages to be handled on Mac during resize. If this message is not handled, then the renderer says that it needs frames but the message is ignored because of the resize lock. Then, the browser never sends begin frame messages and the renderer then never is able to produce a frame. This means that it can't produce a frame of the right size before the resize lock times out and there's jank on screen. R=ccameron@chromium.org,sievers@chromium.org BUG=632603 Committed: https://crrev.com/ee0504e307d6ed18a94a96eae8a4b57adcff4b11 Cr-Commit-Position: refs/heads/master@{#411806} ========== to ========== Fix jank during mac resize Allow SetNeedsBeginFrames messages to be handled on Mac during resize. If this message is not handled, then the renderer says that it needs frames but the message is ignored because of the resize lock. Then, the browser never sends begin frame messages and the renderer then never is able to produce a frame. This means that it can't produce a frame of the right size before the resize lock times out and there's jank on screen. R=ccameron@chromium.org,sievers@chromium.org BUG=632603,638561 Committed: https://crrev.com/ee0504e307d6ed18a94a96eae8a4b57adcff4b11 Cr-Commit-Position: refs/heads/master@{#411806} ==========
Can you take another look at this? The original CL regressed flash videos. This also now depends on https://codereview.chromium.org/2242613003. Apparently the SetNeedsBeginFrame message gets sent really early when a video is fullscreened, before the RenderWidgetHostImpl is initialized. This message would get dropped on the ground and the video would just stop playing and stay all white. Previously this worked because the resize lock held onto that message until after initialization, but once it was passed through and dropped it stopped working.
lgtm
The CQ bit was checked by enne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix jank during mac resize Allow SetNeedsBeginFrames messages to be handled on Mac during resize. If this message is not handled, then the renderer says that it needs frames but the message is ignored because of the resize lock. Then, the browser never sends begin frame messages and the renderer then never is able to produce a frame. This means that it can't produce a frame of the right size before the resize lock times out and there's jank on screen. R=ccameron@chromium.org,sievers@chromium.org BUG=632603,638561 Committed: https://crrev.com/ee0504e307d6ed18a94a96eae8a4b57adcff4b11 Cr-Commit-Position: refs/heads/master@{#411806} ========== to ========== Fix jank during mac resize Allow SetNeedsBeginFrames messages to be handled on Mac during resize. If this message is not handled, then the renderer says that it needs frames but the message is ignored because of the resize lock. Then, the browser never sends begin frame messages and the renderer then never is able to produce a frame. This means that it can't produce a frame of the right size before the resize lock times out and there's jank on screen. R=ccameron@chromium.org,sievers@chromium.org BUG=632603,638561 ==========
The CQ bit was checked by enne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/2246613002/#ps40001 (title: "Fix flash video")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix jank during mac resize Allow SetNeedsBeginFrames messages to be handled on Mac during resize. If this message is not handled, then the renderer says that it needs frames but the message is ignored because of the resize lock. Then, the browser never sends begin frame messages and the renderer then never is able to produce a frame. This means that it can't produce a frame of the right size before the resize lock times out and there's jank on screen. R=ccameron@chromium.org,sievers@chromium.org BUG=632603,638561 ========== to ========== Fix jank during mac resize Allow SetNeedsBeginFrames messages to be handled on Mac during resize. If this message is not handled, then the renderer says that it needs frames but the message is ignored because of the resize lock. Then, the browser never sends begin frame messages and the renderer then never is able to produce a frame. This means that it can't produce a frame of the right size before the resize lock times out and there's jank on screen. R=ccameron@chromium.org,sievers@chromium.org BUG=632603,638561 Committed: https://crrev.com/e5ce61d4966237e3572f3048a6ea39c7ba7d7c64 Cr-Commit-Position: refs/heads/master@{#413601} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e5ce61d4966237e3572f3048a6ea39c7ba7d7c64 Cr-Commit-Position: refs/heads/master@{#413601} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
