Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2246593002: Have Display root ServerWindow origin be (0, 0) for all displays. (Closed)

Created:
4 years, 4 months ago by kylechar
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have Display root ServerWindow origin be (0, 0) for all displays. BUG=637379 Committed: https://crrev.com/b606148d78f48cf072a0e03bd5f094203a7a0252 Cr-Commit-Position: refs/heads/master@{#412621}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M services/ui/ws/display.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
kylechar
4 years, 4 months ago (2016-08-17 16:20:27 UTC) #2
sky
LGTM https://codereview.chromium.org/2246593002/diff/1/services/ui/ws/frame_generator.cc File services/ui/ws/frame_generator.cc (right): https://codereview.chromium.org/2246593002/diff/1/services/ui/ws/frame_generator.cc#newcode73 services/ui/ws/frame_generator.cc:73: const gfx::Rect& output_rect(metrics.bounds.size()); remove the & here.
4 years, 4 months ago (2016-08-17 18:57:54 UTC) #3
kylechar
https://codereview.chromium.org/2246593002/diff/1/services/ui/ws/frame_generator.cc File services/ui/ws/frame_generator.cc (right): https://codereview.chromium.org/2246593002/diff/1/services/ui/ws/frame_generator.cc#newcode73 services/ui/ws/frame_generator.cc:73: const gfx::Rect& output_rect(metrics.bounds.size()); On 2016/08/17 18:57:54, sky wrote: > ...
4 years, 4 months ago (2016-08-17 19:10:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246593002/20001
4 years, 4 months ago (2016-08-17 19:10:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 20:03:11 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 20:10:06 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b606148d78f48cf072a0e03bd5f094203a7a0252
Cr-Commit-Position: refs/heads/master@{#412621}

Powered by Google App Engine
This is Rietveld 408576698