Pass path to gn binary to cronet_licenses.py when building for iOS.

Pass path to gn binary to cronet_licenses.py when building for iOS.

The bot used on iOS have a different repository structure where
Chromium repository is not the primary gclient repository, and
the buildtools is not in the search path of gclient. This cause
failure when invoking gn through searching the PATH as the wrapper
from depot_tools is found and it does not find the real binary.

Instead update cronet_licenses.py to accept the path to the gn
binary and pass the path to the binary in //buildtools/mac when
building for iOS.

Fixes the following compilation error:
  python ../../components/cronet/tools/cronet_licenses.py license cronet/LICENSE --gn
  gn.py: Could not find gn executable at: /b/build/slave/chrome-ios-official/build/buildtools/mac/gn
  Traceback (most recent call last):
    File "../../components/cronet/tools/cronet_licenses.py", line 130, in <module>
      sys.exit(main())
    File "../../components/cronet/tools/cronet_licenses.py", line 108, in main
      third_party_dirs = FindThirdPartyDeps(os.getcwd())
    File "../../components/cronet/tools/cronet_licenses.py", line 74, in FindThirdPartyDeps
      subprocess.check_output(["gn", "gen", tmp_dir])
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 573, in check_output
      raise CalledProcessError(retcode, cmd, output=output)
  subprocess.CalledProcessError: Command '['gn', 'gen', '/b/build/slave/chrome-ios-official/build/src/out/Release-iphoneos/tmppFeoga']' returned non-zero exit status 2

BUG=None

Committed: https://crrev.com/2228c82b13e3663d176b7e76b34eb6d360f0a8f7
Cr-Commit-Position: refs/heads/master@{#411766}

[sdefresne, 2016-08-12 20:01:35]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 20:02:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-08-12 20:02:55]

sdefresne@chromium.org changed reviewers:
+ justincohen@google.com

[sdefresne, 2016-08-12 20:02:56]

I've added //build/util/LASTCHANGE to inputs because after adding
//buildtools/$host_os/gn, the script would only have been re-run if you updated
gn instead of everytime. With this file listed as input it will be re-run when
gclient runhooks is run.

[sdefresne, 2016-08-12 20:03:15]

Please take a look and send to CQ if lgty.

[justincohen, 2016-08-12 20:13:46]

justincohen@chromium.org changed reviewers:
+ justincohen@chromium.org

[justincohen, 2016-08-12 20:13:46]

lgtm

[sdefresne, 2016-08-12 20:25:58]

Description was changed from

==========
Pass path to gn binary to cronet_licenses.py when building for iOS.

The bot used on iOS have a different repository structure where
Chromium repository is not the primary gclient repository, and
the buildtools is not in the search path of gclient. This cause
failure when invoking gn through searching the PATH as the wrapper
from depot_tools is found and it does not find the real binary.

Instead update cronet_licenses.py to accept the path to the gn
binary and pass the path to the binary in //buildtools/mac when
building for iOS.

Fixes the following compilation error:
  python ../../components/cronet/tools/cronet_licenses.py license cronet/LICENSE
--gn
  gn.py: Could not find gn executable at:
/b/build/slave/chrome-ios-official/build/buildtools/mac/gn
  Traceback (most recent call last):
    File "../../components/cronet/tools/cronet_licenses.py", line 130, in
<module>
      sys.exit(main())
    File "../../components/cronet/tools/cronet_licenses.py", line 108, in main
      third_party_dirs = FindThirdPartyDeps(os.getcwd())
    File "../../components/cronet/tools/cronet_licenses.py", line 74, in
FindThirdPartyDeps
      subprocess.check_output(["gn", "gen", tmp_dir])
    File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 573, in check_output
      raise CalledProcessError(retcode, cmd, output=output)
  subprocess.CalledProcessError: Command '['gn', 'gen',
'/b/build/slave/chrome-ios-official/build/src/out/Release-iphoneos/tmppFeoga']'
returned non-zero exit status 2


BUG=None
==========

to

==========
Pass path to gn binary to cronet_licenses.py when building for iOS.

The bot used on iOS have a different repository structure where
Chromium repository is not the primary gclient repository, and
the buildtools is not in the search path of gclient. This cause
failure when invoking gn through searching the PATH as the wrapper
from depot_tools is found and it does not find the real binary.

Instead update cronet_licenses.py to accept the path to the gn
binary and pass the path to the binary in //buildtools/mac when
building for iOS.

Fixes the following compilation error:
  python ../../components/cronet/tools/cronet_licenses.py license cronet/LICENSE
--gn
  gn.py: Could not find gn executable at:
/b/build/slave/chrome-ios-official/build/buildtools/mac/gn
  Traceback (most recent call last):
    File "../../components/cronet/tools/cronet_licenses.py", line 130, in
<module>
      sys.exit(main())
    File "../../components/cronet/tools/cronet_licenses.py", line 108, in main
      third_party_dirs = FindThirdPartyDeps(os.getcwd())
    File "../../components/cronet/tools/cronet_licenses.py", line 74, in
FindThirdPartyDeps
      subprocess.check_output(["gn", "gen", tmp_dir])
    File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 573, in check_output
      raise CalledProcessError(retcode, cmd, output=output)
  subprocess.CalledProcessError: Command '['gn', 'gen',
'/b/build/slave/chrome-ios-official/build/src/out/Release-iphoneos/tmppFeoga']'
returned non-zero exit status 2


BUG=None
==========

[sdefresne, 2016-08-12 20:25:58]

sdefresne@chromium.org changed reviewers:
- justincohen@google.com

[sdefresne, 2016-08-12 20:26:26]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-08-12 20:50:40]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-08-12 20:51:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 21:11:29]

Description was changed from

==========
Pass path to gn binary to cronet_licenses.py when building for iOS.

The bot used on iOS have a different repository structure where
Chromium repository is not the primary gclient repository, and
the buildtools is not in the search path of gclient. This cause
failure when invoking gn through searching the PATH as the wrapper
from depot_tools is found and it does not find the real binary.

Instead update cronet_licenses.py to accept the path to the gn
binary and pass the path to the binary in //buildtools/mac when
building for iOS.

Fixes the following compilation error:
  python ../../components/cronet/tools/cronet_licenses.py license cronet/LICENSE
--gn
  gn.py: Could not find gn executable at:
/b/build/slave/chrome-ios-official/build/buildtools/mac/gn
  Traceback (most recent call last):
    File "../../components/cronet/tools/cronet_licenses.py", line 130, in
<module>
      sys.exit(main())
    File "../../components/cronet/tools/cronet_licenses.py", line 108, in main
      third_party_dirs = FindThirdPartyDeps(os.getcwd())
    File "../../components/cronet/tools/cronet_licenses.py", line 74, in
FindThirdPartyDeps
      subprocess.check_output(["gn", "gen", tmp_dir])
    File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 573, in check_output
      raise CalledProcessError(retcode, cmd, output=output)
  subprocess.CalledProcessError: Command '['gn', 'gen',
'/b/build/slave/chrome-ios-official/build/src/out/Release-iphoneos/tmppFeoga']'
returned non-zero exit status 2


BUG=None
==========

to

==========
Pass path to gn binary to cronet_licenses.py when building for iOS.

The bot used on iOS have a different repository structure where
Chromium repository is not the primary gclient repository, and
the buildtools is not in the search path of gclient. This cause
failure when invoking gn through searching the PATH as the wrapper
from depot_tools is found and it does not find the real binary.

Instead update cronet_licenses.py to accept the path to the gn
binary and pass the path to the binary in //buildtools/mac when
building for iOS.

Fixes the following compilation error:
  python ../../components/cronet/tools/cronet_licenses.py license cronet/LICENSE
--gn
  gn.py: Could not find gn executable at:
/b/build/slave/chrome-ios-official/build/buildtools/mac/gn
  Traceback (most recent call last):
    File "../../components/cronet/tools/cronet_licenses.py", line 130, in
<module>
      sys.exit(main())
    File "../../components/cronet/tools/cronet_licenses.py", line 108, in main
      third_party_dirs = FindThirdPartyDeps(os.getcwd())
    File "../../components/cronet/tools/cronet_licenses.py", line 74, in
FindThirdPartyDeps
      subprocess.check_output(["gn", "gen", tmp_dir])
    File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 573, in check_output
      raise CalledProcessError(retcode, cmd, output=output)
  subprocess.CalledProcessError: Command '['gn', 'gen',
'/b/build/slave/chrome-ios-official/build/src/out/Release-iphoneos/tmppFeoga']'
returned non-zero exit status 2


BUG=None
==========

[commit-bot: I haz the power, 2016-08-12 21:11:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 21:15:56]

Description was changed from

==========
Pass path to gn binary to cronet_licenses.py when building for iOS.

The bot used on iOS have a different repository structure where
Chromium repository is not the primary gclient repository, and
the buildtools is not in the search path of gclient. This cause
failure when invoking gn through searching the PATH as the wrapper
from depot_tools is found and it does not find the real binary.

Instead update cronet_licenses.py to accept the path to the gn
binary and pass the path to the binary in //buildtools/mac when
building for iOS.

Fixes the following compilation error:
  python ../../components/cronet/tools/cronet_licenses.py license cronet/LICENSE
--gn
  gn.py: Could not find gn executable at:
/b/build/slave/chrome-ios-official/build/buildtools/mac/gn
  Traceback (most recent call last):
    File "../../components/cronet/tools/cronet_licenses.py", line 130, in
<module>
      sys.exit(main())
    File "../../components/cronet/tools/cronet_licenses.py", line 108, in main
      third_party_dirs = FindThirdPartyDeps(os.getcwd())
    File "../../components/cronet/tools/cronet_licenses.py", line 74, in
FindThirdPartyDeps
      subprocess.check_output(["gn", "gen", tmp_dir])
    File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 573, in check_output
      raise CalledProcessError(retcode, cmd, output=output)
  subprocess.CalledProcessError: Command '['gn', 'gen',
'/b/build/slave/chrome-ios-official/build/src/out/Release-iphoneos/tmppFeoga']'
returned non-zero exit status 2


BUG=None
==========

to

==========
Pass path to gn binary to cronet_licenses.py when building for iOS.

The bot used on iOS have a different repository structure where
Chromium repository is not the primary gclient repository, and
the buildtools is not in the search path of gclient. This cause
failure when invoking gn through searching the PATH as the wrapper
from depot_tools is found and it does not find the real binary.

Instead update cronet_licenses.py to accept the path to the gn
binary and pass the path to the binary in //buildtools/mac when
building for iOS.

Fixes the following compilation error:
  python ../../components/cronet/tools/cronet_licenses.py license cronet/LICENSE
--gn
  gn.py: Could not find gn executable at:
/b/build/slave/chrome-ios-official/build/buildtools/mac/gn
  Traceback (most recent call last):
    File "../../components/cronet/tools/cronet_licenses.py", line 130, in
<module>
      sys.exit(main())
    File "../../components/cronet/tools/cronet_licenses.py", line 108, in main
      third_party_dirs = FindThirdPartyDeps(os.getcwd())
    File "../../components/cronet/tools/cronet_licenses.py", line 74, in
FindThirdPartyDeps
      subprocess.check_output(["gn", "gen", tmp_dir])
    File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 573, in check_output
      raise CalledProcessError(retcode, cmd, output=output)
  subprocess.CalledProcessError: Command '['gn', 'gen',
'/b/build/slave/chrome-ios-official/build/src/out/Release-iphoneos/tmppFeoga']'
returned non-zero exit status 2

BUG=None

Committed: https://crrev.com/2228c82b13e3663d176b7e76b34eb6d360f0a8f7
Cr-Commit-Position: refs/heads/master@{#411766}
==========

[commit-bot: I haz the power, 2016-08-12 21:15:57]

Patchset 1 (id:??) landed as
https://crrev.com/2228c82b13e3663d176b7e76b34eb6d360f0a8f7
Cr-Commit-Position: refs/heads/master@{#411766}