[Offline Pages]Allow multiple urls to be requested in internal page.

chrome/browser/resources/offline_pages/offline_internals.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('offlineInternals', function() {
   'use strict';
 
   /** @type {!Array<OfflinePage>} */
   var offlinePages = [];
 
@@ skipping 187 matching lines @@
     $('clear-all').onclick = deleteAllPages;
     $('clear-selected').onclick = deleteSelectedPages;
     $('refresh').onclick = refreshAll;
     $('download').onclick = download;
     $('log-model-on').onclick = togglePageModelLog.bind(this, true);
     $('log-model-off').onclick = togglePageModelLog.bind(this, false);
     $('log-request-on').onclick = toggleRequestQueueLog.bind(this, true);
     $('log-request-off').onclick = toggleRequestQueueLog.bind(this, false);
     $('refresh-logs').onclick = refreshLog;
     $('add-to-queue').onclick = function() {
       var saveUrl = $('url').value;

[michaelpg, 2016/08/20 00:46:47]

nit: you don't need this variable

[romax, 2016/08/20 01:23:20]

Done.

-      browserProxy_.addToRequestQueue(saveUrl)
-        .then(function(state) {
-          if (state) {
-            $('save-url-state').textContent =
-              saveUrl + ' has been added to queue.';
-            $('url').value = '';
-            browserProxy_.getRequestQueue().then(fillRequestQueue);
-          } else {
-            $('save-url-state').textContent =
-              saveUrl + ' failed to be added to queue.';
-          }
-        });
+      var saveUrls = saveUrl.split(',');
+      $('save-url-state').textContent = '';
+      for (var i = 0; i < saveUrls.length; i++) {
+        (function() {
+          var it = i;

[michaelpg, 2016/08/20 00:46:47]

if you use let instead of var in the for loop, i will be scoped to the block
like you'd expect in other languages

[romax, 2016/08/20 01:23:20]

Done.

+          browserProxy_.addToRequestQueue(saveUrls[it])
+            .then(function(state) {

[michaelpg, 2016/08/20 00:46:47]

4-space indent, while you're here :-)

[romax, 2016/08/20 01:23:20]

Done.

+              if (state) {
+                $('save-url-state').textContent +=
+                  saveUrls[it] + ' has been added to queue.\n';

[michaelpg, 2016/08/20 00:46:47]

4-space indent

[romax, 2016/08/20 01:23:20]

Done.

+                $('url').value = '';
+                browserProxy_.getRequestQueue().then(fillRequestQueue);

[chili, 2016/08/19 23:08:49]

we're calling .getRequestQueue() a lot...

Optional, but one way to fix:

add var counter = saveUrls.length; before the for-loop
and here,  do
if (counter == 0) {
 browserProxy_.getRequestQueue().then(fillRequestQueue);
}
counter--;

since js is single-threaded, shouldn't have any race conditions

[michaelpg, 2016/08/20 00:46:47]

better, use Promise.all:

var promises = [];
for (let i = 0; i < saveUrls.length; i++) {
  promises.push(browserProxy_.addToRequestQueue(saveUrls[i])
      .then(.......);
}
Promise.all(promises).then(function() {
  browserProxy_.getRequestQueue().then(fillRequestQueue);
});    
    
  promises.push(

[romax, 2016/08/20 01:23:20]

Done.

+              } else {
+                $('save-url-state').textContent +=
+                  saveUrls[it] + ' failed to be added to queue.\n';

[michaelpg, 2016/08/20 00:46:47]

4-space indent

[romax, 2016/08/20 01:23:20]

Done.

+              }
+            });
+        })();
+      }
     };
 
     refreshAll();
   }
 
   // Return an object with all of the exports.
   return {
     initialize: initialize,
   };
 });
 
 document.addEventListener('DOMContentLoaded', offlineInternals.initialize);