Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2246543002: Enable ALPC lockdown on >= win10 (Closed)

Created:
4 years, 4 months ago by liamjm (20p)
Modified:
4 years, 1 month ago
Reviewers:
Will Harris
CC:
chromium-reviews, jam, darin-cc_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ALPC lockdown on >= win10 to further tighten up the sandbox on Windows. This is already enabled in sandbox tests, but this CL will enable it for all tests, and for all chrome renderers. BUG=464430 Committed: https://crrev.com/c9f56c97ccec49da955caf9b7e548f1bdd66144e Cr-Commit-Position: refs/heads/master@{#428799}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/common/sandbox_win.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
liamjm (20p)
4 years, 1 month ago (2016-10-29 21:30:57 UTC) #3
Will Harris
lgtm although this might break everything. prepare for a rapid revert :)
4 years, 1 month ago (2016-10-31 03:21:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246543002/20001
4 years, 1 month ago (2016-10-31 19:36:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 20:49:24 UTC) #10
Will Harris
👻!!
4 years, 1 month ago (2016-10-31 20:50:27 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c9f56c97ccec49da955caf9b7e548f1bdd66144e Cr-Commit-Position: refs/heads/master@{#428799}
4 years, 1 month ago (2016-10-31 20:52:50 UTC) #13
Will Harris
4 years, 1 month ago (2016-11-08 20:37:54 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2488803002/ by wfh@chromium.org.

The reason for reverting is: seems to be causing crashes with Avast! and issues
with SharedMemory/HandleVerifier..

Powered by Google App Engine
This is Rietveld 408576698