Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2246503003: Assert fDeviceClipBounds is always empty when clip is empty (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@qr
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Assert fDeviceClipBounds is always empty when clip is empty I've fixed a few issues where this assert triggers. The nastiest case is when the client sets the clip to a strange version of an empty rect (Ex: L,T,R,B=0,0,0,10). I think I've made sufficient fixes so that fDeviceClipBounds is always empty when clip is empty. Let's test it though. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246503003 Committed: https://skia.googlesource.com/skia/+/0c685ee188a5e500df25a34fa6edfceb4cbb795c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
msarett
Planning to land this after/if the roll succeeds on the original change.
4 years, 4 months ago (2016-08-12 15:50:30 UTC) #8
mtklein
lgtm
4 years, 4 months ago (2016-08-12 16:27:04 UTC) #9
reed1
lgtm
4 years, 4 months ago (2016-08-12 22:28:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246503003/1
4 years, 4 months ago (2016-08-14 20:16:33 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-14 20:51:20 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0c685ee188a5e500df25a34fa6edfceb4cbb795c

Powered by Google App Engine
This is Rietveld 408576698