V8: Make sure infra failures fail overall build

V8: Make sure infra failures fail overall build

BUG=

Committed: https://chromium.googlesource.com/chromium/tools/build/+/a93ede2801326ddd7ce4574083872e5e54550c05

[Michael Achenbach, 2016-08-12 13:30:47]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org

[Michael Achenbach, 2016-08-12 13:30:47]

PTAL

[tandrii(chromium), 2016-08-12 13:42:01]

lgtm

[tandrii(chromium), 2016-08-12 13:42:04]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-08-12 13:42:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 13:46:09]

Description was changed from

==========
V8: Make sure infra failures fail overall build

BUG=
==========

to

==========
V8: Make sure infra failures fail overall build

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/a93ede2801326ddd7ce4...
==========

[commit-bot: I haz the power, 2016-08-12 13:46:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/a93ede2801326ddd7ce4...

[Michael Achenbach, 2016-08-12 15:09:14]

Not liking this exception:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20GC%20Stress/...

But in that case none of the shards did complete. But I still wonder if the
change to infrafailure maybe changed the way we access the json output of the
active result.

I'll also wait for the other bot to finish:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

[tandrii(chromium), 2016-08-12 15:42:31]

On 2016/08/12 15:09:14, machenbach (OOO until Aug 28) wrote:
> Not liking this exception:
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20GC%20Stress/...
> 
> But in that case none of the shards did complete. But I still wonder if the
> change to infrafailure maybe changed the way we access the json output of the
> active result.
> 
> I'll also wait for the other bot to finish:
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

and it has just failed with infra failure :)

[Michael Achenbach, 2016-08-12 17:09:34]

On 2016/08/12 15:42:31, tandrii(chromium) wrote:
> On 2016/08/12 15:09:14, machenbach (OOO until Aug 28) wrote:
> > Not liking this exception:
> >
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20GC%20Stress/...
> > 
> > But in that case none of the shards did complete. But I still wonder if the
> > change to infrafailure maybe changed the way we access the json output of
the
> > active result.
> > 
> > I'll also wait for the other bot to finish:
> >
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...
> 
> and it has just failed with infra failure :)

Yes, the second one looks good. Other builds are also fine, both passes and
builds with test failures. The exception above has yet another reason. It might
actually be an assert that earlier got also swallowed by the return. But it's
not so important as it at least makes the build red.