Issue 22465006: pdfviewer: pass the page number, report failure if at least one render fails, and check that xref s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22465006: pdfviewer: pass the page number, report failure if at least one render fails, and check that xref s… (Closed)

Created:
7 years, 4 months ago by edisonn

Modified:
7 years, 4 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

pdfviewer: load image pain settings (like transparency), pass the page number, report failure if at least one render fails, and check that xref section starts with xref keyword. Committed: https://code.google.com/p/skia/source/detail?r=10588

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -14 lines)			Patch
M	experimental/PdfViewer/SkPdfRenderer.cpp	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	experimental/PdfViewer/pdf_viewer_main.cpp	View		3 chunks	+7 lines, -10 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

edisonn

7 years, 4 months ago (2013-08-06 21:48:47 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 manually as r10588 (presubmit successful).

Expand Messages | Collapse Messages