Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2246483002: [debugger] add mixed-stack tests. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] add mixed-stack tests. R=jgruber@chromium.org, mstarzinger@chromium.org BUG=v8:5265 Committed: https://crrev.com/f03bebc77da30de2d15f52e482c015b94cd9000b Cr-Commit-Position: refs/heads/master@{#38621}

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -0 lines) Patch
M src/runtime/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A test/mjsunit/ignition/debug-break-mixed-stack.js View 1 chunk +52 lines, -0 lines 0 comments Download
A test/mjsunit/ignition/debug-step-mixed-stack.js View 1 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Yang
4 years, 4 months ago (2016-08-12 12:37:43 UTC) #1
Yang
On 2016/08/12 12:37:43, Yang wrote: Note that these tests only work as intended with --ignition-staging ...
4 years, 4 months ago (2016-08-12 12:38:12 UTC) #2
Michael Starzinger
LGTM on the runtime functions.
4 years, 4 months ago (2016-08-12 12:49:08 UTC) #5
jgruber
LGTM https://codereview.chromium.org/2246483002/diff/1/test/mjsunit/ignition/debug-step-mixed-stack.js File test/mjsunit/ignition/debug-step-mixed-stack.js (right): https://codereview.chromium.org/2246483002/diff/1/test/mjsunit/ignition/debug-step-mixed-stack.js#newcode5 test/mjsunit/ignition/debug-step-mixed-stack.js:5: // Flags: --expose-debug-as debug --allow-natives-syntax Would it be ...
4 years, 4 months ago (2016-08-12 12:51:34 UTC) #6
Yang
https://codereview.chromium.org/2246483002/diff/1/test/mjsunit/ignition/debug-step-mixed-stack.js File test/mjsunit/ignition/debug-step-mixed-stack.js (right): https://codereview.chromium.org/2246483002/diff/1/test/mjsunit/ignition/debug-step-mixed-stack.js#newcode5 test/mjsunit/ignition/debug-step-mixed-stack.js:5: // Flags: --expose-debug-as debug --allow-natives-syntax On 2016/08/12 12:51:34, jgruber ...
4 years, 4 months ago (2016-08-12 13:27:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246483002/20001
4 years, 4 months ago (2016-08-12 13:27:36 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 13:51:06 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 13:51:30 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f03bebc77da30de2d15f52e482c015b94cd9000b
Cr-Commit-Position: refs/heads/master@{#38621}

Powered by Google App Engine
This is Rietveld 408576698