Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 2246473002: [heap] ObjectStats: Various new categories (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] ObjectStats: Various new categories - Add object template categories. - Add optimized code literals. - Add compilation cache hash tables. - Report overhead for code cache when used as hashtable. BUG=chromium:631094 Committed: https://crrev.com/5d9deb255c1799221afde5eb41307b4a87916de7 Cr-Commit-Position: refs/heads/master@{#38667}

Patch Set 1 #

Patch Set 2 : Various new categories #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
M src/flag-definitions.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/object-stats.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/heap/object-stats.cc View 1 7 chunks +52 lines, -2 lines 0 comments Download
M src/objects.h View 1 4 chunks +5 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Hannes Payer (out of office)
lgtm
4 years, 4 months ago (2016-08-16 18:58:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246473002/20001
4 years, 4 months ago (2016-08-16 18:58:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 19:26:26 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 19:26:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d9deb255c1799221afde5eb41307b4a87916de7
Cr-Commit-Position: refs/heads/master@{#38667}

Powered by Google App Engine
This is Rietveld 408576698