test/cctest/compiler/test-code-assembler.cc - Issue 2246463002: [compiler] Remove compiler internals from CodeAssembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-code-assembler.cc

Issue 2246463002: [compiler] Remove compiler internals from CodeAssembler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/compiler/test-code-assembler.cc

diff --git a/test/cctest/compiler/test-code-assembler.cc b/test/cctest/compiler/test-code-assembler.cc

index 9e0d488264b9e5c3f8fadd72114007f8c7950703..d9bb9346f59a8768381943f55929b2c80b9e22b1 100644

--- a/test/cctest/compiler/test-code-assembler.cc

+++ b/test/cctest/compiler/test-code-assembler.cc

@@ -21,7 +21,7 @@ Node* SmiTag(CodeAssemblerTester& m, Node* value) {

Smi::IsValid(constant_value)) {

return m.SmiConstant(Smi::FromInt(constant_value));

}

- return m.WordShl(value, m.SmiShiftBitsConstant());

+ return m.WordShl(value, m.IntPtrConstant(kSmiShiftSize + kSmiTagSize));

}

Node* UndefinedConstant(CodeAssemblerTester& m) {