Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2246443002: Do not assume that perf tests always have end_time (Closed)

Created:
4 years, 4 months ago by perezju
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Do not assume that perf tests always have end_time Sometimes, e.g. if a test did not run, the output of "get perf test list" might not include 'end_time'. If that's the case, we get a timestamp of our own. BUG=637076, 632309 Committed: https://chromium.googlesource.com/chromium/tools/build/+/f1b32044c0c3d1a6f8e1c58fa05534ef346ea7c2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -66 lines) Patch
M scripts/slave/recipe_modules/chromium_android/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/api.py View 3 chunks +6 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/enable_platform_mode_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/last_known_devices_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_high_battery_temp_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_low_battery_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_disable_location_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_user_build_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_failure.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_infra_failure.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/timestamp_as_point_id_basic.json View 2 chunks +1 line, -2 lines 1 comment Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/host_info_failure.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/missing_device.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/test_failure.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
perezju
https://codereview.chromium.org/2246443002/diff/1/scripts/slave/recipe_modules/chromium_android/example.expected/timestamp_as_point_id_basic.json File scripts/slave/recipe_modules/chromium_android/example.expected/timestamp_as_point_id_basic.json (right): https://codereview.chromium.org/2246443002/diff/1/scripts/slave/recipe_modules/chromium_android/example.expected/timestamp_as_point_id_basic.json#newcode836 scripts/slave/recipe_modules/chromium_android/example.expected/timestamp_as_point_id_basic.json:836: "--point-id=1337000001", our own timestamp from m.time.time().
4 years, 4 months ago (2016-08-12 10:19:03 UTC) #2
sullivan
lgtm
4 years, 4 months ago (2016-08-12 11:05:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246443002/1
4 years, 4 months ago (2016-08-12 11:14:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3097475db734ce10)
4 years, 4 months ago (2016-08-12 11:25:04 UTC) #8
perezju
Ah, still needing an owner stamp. :)
4 years, 4 months ago (2016-08-12 11:29:20 UTC) #9
bpastene
lgtm, thanks for clearing that up
4 years, 4 months ago (2016-08-12 17:01:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246443002/1
4 years, 4 months ago (2016-08-12 17:25:27 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 17:33:06 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/f1b32044c0c3d1a6f8e1...

Powered by Google App Engine
This is Rietveld 408576698