Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1878)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2246363003: [DO NOT COMMIT] Test implementation of converting same URL navigation into a reload Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased and logging. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 52c0c387f4980c2760f4f1f98f267f606203db3c..931b4e32ab8a8a0d1cdcb0dd05c5c3929e313e76 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1080,6 +1080,9 @@ RenderFrameImpl::RenderFrameImpl(const CreateParams& params)
frame_binding_(this),
has_accessed_initial_document_(false),
weak_factory_(this) {
+ LOG(ERROR) << "RF[" << this << "]::RF: "
+ << " routing_id:" << routing_id_;
+
// We don't have a shell::Connection at this point, so use nullptr.
// TODO(beng): We should fix this, so we can apply policy about which
// interfaces get exposed.
@@ -1151,6 +1154,7 @@ RenderFrameImpl::~RenderFrameImpl() {
render_view_->UnregisterRenderFrame(this);
g_routing_id_frame_map.Get().erase(routing_id_);
RenderThread::Get()->RemoveRoute(routing_id_);
+ LOG(ERROR) << "RF[" << this << "]::~RF";
}
void RenderFrameImpl::BindToWebFrame(blink::WebLocalFrame* web_frame) {
@@ -1711,6 +1715,8 @@ void RenderFrameImpl::OnSwapOut(
}
void RenderFrameImpl::OnDeleteFrame() {
+ LOG(ERROR) << "RF[" << this << "]::OnDeleteFrame:";
+
// TODO(nasko): If this message is received right after a commit has
// swapped a RenderFrameProxy with this RenderFrame, the proxy needs to be
// recreated in addition to the RenderFrame being deleted.
@@ -2223,6 +2229,9 @@ bool RenderFrameImpl::RunJavaScriptMessage(JavaScriptMessageType type,
const base::string16& default_value,
const GURL& frame_url,
base::string16* result) {
+ LOG(ERROR) << "RF[" << this << "]::RunJavaScriptMessage: "
+ << " suppress:" << suppress_further_dialogs_;
+
// Don't allow further dialogs if we are waiting to swap out, since the
// ScopedPageLoadDeferrer in our stack prevents it.
if (suppress_further_dialogs_)
@@ -2824,6 +2833,9 @@ void RenderFrameImpl::didChangeOpener(blink::WebFrame* opener) {
void RenderFrameImpl::frameDetached(blink::WebLocalFrame* frame,
DetachType type) {
+ LOG(ERROR) << "RF[" << this << "]::frameDetached: "
+ << " type:" << static_cast<int>(type);
+
// NOTE: This function is called on the frame that is being detached and not
// the parent frame. This is different from createChildFrame() which is
// called on the parent frame.
@@ -3201,6 +3213,9 @@ void RenderFrameImpl::didStartProvisionalLoad(blink::WebLocalFrame* frame,
"url", ds->request().url().string().utf8());
DocumentState* document_state = DocumentState::FromDataSource(ds);
+ LOG(ERROR) << "RF[" << this << "]::didStartProvisionalLoad: "
+ << " url:" << ds->request().url().string().utf8().substr(0, 250);
+
// Update the request time if WebKit has better knowledge of it.
if (document_state->request_time().is_null() &&
triggering_event_time != 0.0) {
@@ -3240,6 +3255,8 @@ void RenderFrameImpl::didReceiveServerRedirectForProvisionalLoad(
blink::WebLocalFrame* frame) {
DCHECK_EQ(frame_, frame);
+ LOG(ERROR) << "RF[" << this << "]::didReceiveServerRedirectForProvisionalLoad:";
+
// We don't use HistoryController in OOPIF enabled modes.
if (SiteIsolationPolicy::UseSubframeNavigationEntries())
return;
@@ -3257,6 +3274,9 @@ void RenderFrameImpl::didFailProvisionalLoad(
WebDataSource* ds = frame->provisionalDataSource();
DCHECK(ds);
+ LOG(ERROR) << "RF[" << this << "]::didFailProvisionalLoad: "
+ << " url:" << ds->request().url().string().utf8().substr(0, 250);
+
const WebURLRequest& failed_request = ds->request();
// Notify the browser that we failed a provisional load with an error.
@@ -3328,6 +3348,9 @@ void RenderFrameImpl::didCommitProvisionalLoad(
}
}
+ LOG(ERROR) << "RF[" << this << "]::didCommitProvisionalLoad: "
+ << " url:" << GetLoadingUrl().spec().substr(0, 250);
+
if (proxy_routing_id_ != MSG_ROUTING_NONE) {
RenderFrameProxy* proxy =
RenderFrameProxy::FromRoutingID(proxy_routing_id_);
@@ -3593,6 +3616,9 @@ void RenderFrameImpl::didFinishDocumentLoad(blink::WebLocalFrame* frame) {
DocumentState* document_state = DocumentState::FromDataSource(ds);
document_state->set_finish_document_load_time(Time::Now());
+ LOG(ERROR) << "RF[" << this << "]::didFinishDocumentLoad: "
+ << " url:" << frame->document().url().string().utf8().substr(0, 250);
+
Send(new FrameHostMsg_DidFinishDocumentLoad(routing_id_));
FOR_EACH_OBSERVER(RenderViewObserver, render_view_->observers(),
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698