remove unused test expectation files

test/codegen_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Tests code generation.
 ///
 /// Runs Dart Dev Compiler on all input in the `codegen` directory and checks
 /// that the output is what we expected.
 library dev_compiler.test.codegen_test;
 
@@ skipping 84 matching lines @@
   // Our default compiler options. Individual tests can override these.
   var defaultOptions = ['--no-source-map', '--no-summarize'];
   var compilerArgParser = new ArgParser();
   CompilerOptions.addArguments(compilerArgParser);
 
   // Compile each test file to JS and put the result in gen/codegen_output.
   for (var testFile in testFiles) {
     var relativePath = path.relative(testFile, from: codegenTestDir);
 
     // Only compile the top-level files for generating coverage.
-    if (codeCoverage && path.dirname(relativePath) != ".") continue;
+    bool isTopLevelTest = path.dirname(relativePath) == ".";
+    if (codeCoverage && !isTopLevelTest) continue;
 
     var name = path.withoutExtension(relativePath);
     test('dartdevc $name', () {
-      var relativeDir = path.dirname(relativePath);
-      var outDir = path.join(codegenOutputDir, relativeDir);
-      var expectDir = path.join(codegenExpectDir, relativeDir);
-
       // Check if we need to use special compile options.
       var contents = new File(testFile).readAsStringSync();
       var match =
           new RegExp(r'// compile options: (.*)').matchAsPrefix(contents);
 
       var args = defaultOptions.toList();
       if (match != null) {
         args.addAll(match.group(1).split(' '));
       }
       var options =
           new CompilerOptions.fromArguments(compilerArgParser.parse(args));
 
       // Collect any other files we've imported.
       var files = new Set<String>();
       _collectTransitiveImports(contents, files, from: testFile);
-      var moduleName =
-          path.withoutExtension(path.relative(testFile, from: codegenTestDir));
-      var unit = new BuildUnit(moduleName, path.dirname(testFile),
-          files.toList(), _moduleForLibrary);
+      var unit = new BuildUnit(
+          name, path.dirname(testFile), files.toList(), _moduleForLibrary);
       var module = compiler.compile(unit, options);
-      _writeModule(
-          path.join(outDir, path.basenameWithoutExtension(testFile)),
-          path.join(expectDir, path.basenameWithoutExtension(testFile)),
-          module);
+      _writeModule(path.join(codegenOutputDir, name),
+          isTopLevelTest ? path.join(codegenExpectDir, name) : null, module);
     });
   }
 
   if (filePattern.hasMatch('sunflower')) {
     _buildSunflower(compiler, codegenOutputDir, codegenExpectDir);
   }
 
   if (codeCoverage) {
     test('build_sdk code coverage', () {
       return build_sdk.main(['--dart-sdk', sdkDir, '-o', codegenOutputDir]);
     });
   }
 }
 
 void _writeModule(String outPath, String expectPath, JSModuleFile result) {
   _ensureDirectory(path.dirname(outPath));
-  _ensureDirectory(path.dirname(expectPath));
 
   String errors = result.errors.join('\n');
   if (errors.isNotEmpty && !errors.endsWith('\n')) errors += '\n';
   new File(outPath + '.txt').writeAsStringSync(errors);
 
   var jsFile = new File(outPath + '.js');
   var summaryFile = new File(outPath + '.sum');
-  var expectFile = new File(expectPath + '.js');
   var errorFile = new File(outPath + '.err');
 
   if (result.isValid) {
     jsFile.writeAsStringSync(result.code);
     if (result.summaryBytes != null) {
       summaryFile.writeAsBytesSync(result.summaryBytes);
     }
     if (result.sourceMap != null) {
       var mapPath = outPath + '.js.map';
       new File(mapPath)
           .writeAsStringSync(JSON.encode(result.placeSourceMap(mapPath)));
     }
 
-    expectFile.writeAsStringSync(result.code);
-
     // There are no errors, so delete any stale ".err" file.
     if (errorFile.existsSync()) {
       errorFile.deleteSync();
     }
   } else {
     // Also write the errors to a '.err' file for easy counting.
     var moduleName = result.name;
     var libraryName = path.split(moduleName).last;
     var count = "[error]".allMatches(errors).length;
     var text = '''
 dart_library.library('$moduleName', null, [
   'dart_sdk',
   'expect'
 ], function(exports, dart_sdk, expect) {
   const message = `DDC Compilation Error: $moduleName has $count errors`;
   const error = new Error(message);
   exports.$libraryName = Object.create(null);
   exports.$libraryName.main = function() {
     throw error;
   }
 });
     ''';
     errorFile.writeAsStringSync(text);
 
     // There are errors, so delete any stale ".js" file.
     if (jsFile.existsSync()) {
       jsFile.deleteSync();
     }
+  }
 
-    // There are errors, so delete any stale expect ".js" file.
-    if (expectFile.existsSync()) {
-      expectFile.deleteSync();
+  // Write the expectation file if needed.
+  // Generally speaking we try to avoid these tests, but they are occasionally
+  // useful.
+  if (expectPath != null) {
+    _ensureDirectory(path.dirname(expectPath));
+
+    var expectFile = new File(expectPath + '.js');
+    if (result.isValid) {
+      expectFile.writeAsStringSync(result.code);
+    } else {
+      // There are errors, so delete any stale expect ".js" file.
+      if (expectFile.existsSync()) {
+        expectFile.deleteSync();
+      }
+      expectFile.writeAsStringSync("//FAILED TO COMPILE");
     }
-    expectFile.writeAsStringSync("//FAILED TO COMPILE");
   }
 }
 
 void _buildSunflower(
     ModuleCompiler compiler, String outputDir, String expectDir) {
   var baseDir = path.join(codegenDir, 'sunflower');
   var files = ['sunflower', 'circle', 'painter']
       .map((f) => path.join(baseDir, '$f.dart'))
       .toList();
   var input = new BuildUnit('sunflower', baseDir, files, _moduleForLibrary);
@@ skipping 120 matching lines @@
 /// Simplified from ParseDartTask.resolveDirective.
 String _resolveDirective(UriBasedDirective directive) {
   StringLiteral uriLiteral = directive.uri;
   String uriContent = uriLiteral.stringValue;
   if (uriContent != null) {
     uriContent = uriContent.trim();
     directive.uriContent = uriContent;
   }
   return directive.validate() == null ? uriContent : null;
 }