src/snapshot/code-serializer.cc - Issue 2246333003: Store information about builtins in descriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/snapshot/code-serializer.cc

Issue 2246333003: Store information about builtins in descriptors (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rename to Builtins::Descriptor Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/snapshot/code-serializer.cc

diff --git a/src/snapshot/code-serializer.cc b/src/snapshot/code-serializer.cc

index 8d2f5d933994cbab63e6451973137fe11c50496a..4ac80119805e0883cb2920aa4310629d25050035 100644

--- a/src/snapshot/code-serializer.cc

+++ b/src/snapshot/code-serializer.cc

@@ -124,7 +124,7 @@ void CodeSerializer::SerializeBuiltin(int builtin_index, HowToCode how_to_code,

DCHECK((how_to_code == kPlain && where_to_point == kStartOfObject) ||

(how_to_code == kPlain && where_to_point == kInnerPointer) ||

(how_to_code == kFromCode && where_to_point == kInnerPointer));

- DCHECK_LT(builtin_index, Builtins::builtin_count);

+ DCHECK_LT(builtin_index, Builtins::BUILTIN_COUNT);

DCHECK_LE(0, builtin_index);

if (FLAG_trace_serializer) {