Issue 224633002: Add GN buildfile for gfx

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 224633002: Add GN buildfile for gfx (Closed)

Created:
6 years, 8 months ago by brettw

Modified:
6 years, 8 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add GN buildfile for gfx Adds libjpeg and some global flags for Ozone from the GYP build. Improves error messages for mismatched item types I noticed when writing this patch (changes in builder.cc). BUG= R=bradnelson@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263086

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : remove gtk #

Patch Set 4 : #

Patch Set 5 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+508 lines, -5 lines)			Patch
M	BUILD.gn	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	build/config/linux/BUILD.gn	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	build/config/ui.gni	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	skia/skia_gn_files.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
A	third_party/libjpeg/BUILD.gn	View		1 chunk	+67 lines, -0 lines	0 comments	Download
M	tools/gn/builder.cc	View		2 chunks	+7 lines, -4 lines	0 comments	Download
A	ui/gfx/BUILD.gn	View	1 2 3	1 chunk	+426 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bradn

lgtm https://codereview.chromium.org/224633002/diff/20001/ui/gfx/BUILD.gn File ui/gfx/BUILD.gn (right): https://codereview.chromium.org/224633002/diff/20001/ui/gfx/BUILD.gn#newcode211 ui/gfx/BUILD.gn:211: #"path_gtk.cc", ?

6 years, 8 months ago (2014-04-03 23:27:17 UTC) #2

brettw

https://codereview.chromium.org/224633002/diff/20001/ui/gfx/BUILD.gn File ui/gfx/BUILD.gn (right): https://codereview.chromium.org/224633002/diff/20001/ui/gfx/BUILD.gn#newcode211 ui/gfx/BUILD.gn:211: #"path_gtk.cc", On 2014/04/03 23:27:18, bradn wrote: > ? I ...

6 years, 8 months ago (2014-04-04 16:52:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r263086.

Expand Messages | Collapse Messages