Chromium Code Reviews Chromium Code Reviews
Issue 2246303003:
Use testharness.js instead of js-test.js in fast/images. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html b/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html |
| index ea833ef780feb9c43ee952b3d713b5c48feac58d..175255db0af34357b94909b4daadfff79c3fbb1e 100644 |
| --- a/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html |
| +++ b/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html |
| @@ -1,29 +1,17 @@ |
| <!DOCTYPE html> |
| <html> |
|
fs
2016/08/16 10:54:59
You can drop <html>, <body> and their correspondin
sivag
2016/08/16 13:44:02
Done.
|
| -<script src="../../resources/js-test.js"></script> |
| +<title>Test that removing invalid event listeners from image documents doesn't crash.</title> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| <body> |
| <script> |
| -description("Test that removing invalid event listeners from image documents doesn't crash."); |
| - |
| -window.jsTestIsAsync = true; |
| - |
| -if (window.testRunner) { |
| - testRunner.dumpAsText(); |
| - testRunner.setCanOpenWindows(); |
|
fs
2016/08/16 10:54:59
Don't you still need this?
sivag
2016/08/16 13:44:02
Done.
|
| - testRunner.waitUntilDone(); |
| -} |
| - |
| -function runTest() |
| -{ |
| +async_test(function(t) { |
| var newWindow = window.open("resources/dice.png"); |
| - newWindow.onload = function() { |
| + newWindow.onload = t.step_func_done(function() { |
| newWindow.addEventListener("resize", function () {;}); |
| newWindow.removeEventListener("resize", 2); |
| - testPassed("No crash."); |
| - finishJSTest(); |
| - }; |
| -} |
| -runTest(); |
| + }); |
| +}); |
| </script> |
| </body> |
| </html> |
